[
https://issues.apache.org/jira/browse/IGNITE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304854#comment-16304854
]
Denis Magda commented on IGNITE-7304:
-------------------------------------
[~bbarin],
Please consider a couple of review notes:
* Instead of passing these parameters {{AWSCredentialsProvider
awsCredentialsProvider, String loadBalancerName, String region, int port}} into
the constructor, create a separate setter method for each leaving constructor's
parameters list empty. Every setter method needs to have a documentation on
what the parameter is for. Refer to other IP finders to see how it's done.
* Add a documentation to the class level (before {{class
TcpDiscoveryElbIpFinder}}) sharing more info about the IP finder. You can refer
to other IP finders as to an example.
* How can we test this IP finder? If it requires us to host something on Amazon
then I would do a simple test checking that methods don't fail with some
unknown reason like it's done for {{TcpDiscoveryKubernetesIpFinderSelfTest}}.
> Node discovery through AWS ELB
> ------------------------------
>
> Key: IGNITE-7304
> URL: https://issues.apache.org/jira/browse/IGNITE-7304
> Project: Ignite
> Issue Type: New Feature
> Components: aws
> Affects Versions: 2.3
> Reporter: Bruno Barin
>
> Would be nice to have AWS ELB node discovery out of the box with Ignite.
> I've already have developed code to perform this and is working well in
> production if you agree, i can PR my solution
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
