[
https://issues.apache.org/jira/browse/IGNITE-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300298#comment-16300298
]
Ilya Kasnacheev commented on IGNITE-7107:
-----------------------------------------
I have rebuilt RPM with this spec and have a number of objections for the
provided patch. Note that I have actually tested it with 2.3 binary
distribution.
* I have noticed that both spec and DEVNOTES are made to use tabs alongside
with spaces. I thought we are avoiding tabs? Please confirm that usage of tabs
is desired in this case.
* Maybe it's my CentOS but initially build will fail with the following
message, which I had to fix in spec
{code}
+ cd 'apache-ignite-*'
/var/tmp/rpm-tmp.KwOoyl: line 34: cd: apache-ignite-*: No such file or directory
{code}
* We absolutely should not inline configuration files (such as
default-config.xml) into build scripts. We should just copy over
default-config.xml from config/ to /etc, with dependencies if needed.
* We should discuss whether default discovery is applicable for packaged
Ignite, but it should not list a random IP as it does now.
* I'm not sure PDS should be ON by default. Better provide it in examples but
disable by default.
Less severe:
* I cannot comment on firewall rules validity, but firewall and service
configurations should be stored in sources, as files, supplied with release
(somewhere in packages/) and installed from there
* sqlline.sh fails to connect initially, needs to be specified
jdbc:ignite:thin://localhost, then it works. I think that sqlline should become
available as /usr/bin/apache-ignite-sqlline for example, to be in $PATH. And
figure out how to connect by itself.
* ignitevisorcmd.sh becomes confused. first it scans /usr/share/apache-ignite
for configs, then it fails to write to /usr/share/apache-ignite/work. We
should consider how it can be fixed (a symlink from
/usr/share/apache-ignite/config to /etc/apache-ignite, perhaps, and work dir in
/tmp?), and made available as /usr/bin/apache-ignite-visorcmd.
Minor things to consider:
* Not everything should go into /usr/share. classpath libs belong to /usr/lib.
* We are building from binary package and not from sources. If it is used by
internal RPM building this is tolerable, but any distro or repository will want
to build from source.
* spec contains version (2.4.0) - will be needed to be changed for every
release. I'm not sure if it's possible to extract.
* Package description may be improved. service description lacks '-' in "In
Memory".
> Apache Ignite RPM packages
> --------------------------
>
> Key: IGNITE-7107
> URL: https://issues.apache.org/jira/browse/IGNITE-7107
> Project: Ignite
> Issue Type: New Feature
> Components: binary
> Reporter: Peter Ivanov
> Assignee: Peter Ivanov
> Priority: Critical
> Labels: important
> Fix For: 2.4
>
>
> Pack apache-ignite into RPM package for distribution through RPM-based Linux
> distros (Fedora / CentOS / RHEL, etc.)
> Iteration (I): bundle (all-in-one) RPM
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
