[ 
https://issues.apache.org/jira/browse/IGNITE-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283661#comment-16283661
 ] 

Vladimir Ozerov commented on IGNITE-4192:
-----------------------------------------

[~al.psc], my comments:
1) {{JdbcThinConnection.ctor}} - {{autoCommit}} should be set {{true}} by 
default as per JDBC spec
2) {{JdbcThinConnection.setAutoCommit}} - user should be able to work with both 
autoCommit modes, why are we restricting this?
3) {{JdbcThinConnection.commit}} - commit with active transaction should be 
no-op instead of exception
4) {{JdbcThinConnection.rollback}} - same as p.3
5) {{JdbcThinConnection}} - if {{autoCommit = false}}, transaction should be 
started on the first call to any operation
6) {{JdbcThinConnection}} - JDBC spec requirement is missing - if autoCommit 
mode is changed during transaction, it should be committed forcefully
7) {{SqlTransactionsSelfTest}} is not included into a test suite
8) Please investigate what other vendors do in case {{BEGIN}} is called on 
already existing transaction. Most probably we should commit previous TX and 
start a new one instead of throwing an exception
9) {{ROLLBACK}} on non-existing TX should be no-op

> SQL TX: JDBC driver support
> ---------------------------
>
>                 Key: IGNITE-4192
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4192
>             Project: Ignite
>          Issue Type: Task
>          Components: jdbc
>            Reporter: Denis Magda
>            Assignee: Alexander Paschenko
>              Labels: iep-3, sql
>             Fix For: 2.4
>
>
> To support execution of DML and SELECT statements inside of a transaction 
> started from JDBC driver side.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to