[
https://issues.apache.org/jira/browse/IGNITE-6904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279885#comment-16279885
]
Sergey Kalashnikov commented on IGNITE-6904:
--------------------------------------------
[~rkondakov] Roma, I have reviewed the code and it looks good.
Perhaps you may add a test to confirm that partition reservations are released
in case the cursor is closed and last page is never requested.
As far as I can tell looking at the code it is OK, but having a test would be
great.
[~vozerov], what do you think?
> SQL: partition reservations are released too early in lazy mode
> ---------------------------------------------------------------
>
> Key: IGNITE-6904
> URL: https://issues.apache.org/jira/browse/IGNITE-6904
> Project: Ignite
> Issue Type: Bug
> Components: sql
> Affects Versions: 2.3
> Reporter: Vladimir Ozerov
> Assignee: Roman Kondakov
> Fix For: 2.4
>
>
> In lazy mode we advance query execution as new page requests arrive. However,
> method {{GridMapQueryExecutor#onQueryRequest0}} releases partition
> reservations when only the very first page is processed:
> {code}
> finally {
> GridH2QueryContext.clearThreadLocal();
> if (distributedJoinMode == OFF)
> qctx.clearContext(false);
> }
> {code}
> It means that incorrect results may be returned on unstable topology. We need
> to release partitions only after the whole query is executed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
