[ 
https://issues.apache.org/jira/browse/IGNITE-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259466#comment-16259466
 ] 

Sergey Kalashnikov commented on IGNITE-6876:
--------------------------------------------

@Igor Sapego, I only have 2 minor comments to add:
1. SocketClient::TrySetOptions(), the case when setting non-blocking mode has 
failed.
Can you extend the message you put to diagnostic record with a remark that 
connection timeout functionality will not work because of that?

2. File attributes_test.cpp. 
Misprint in the name of the test 
BOOST_AUTO_TEST_CASE(ConnetionAttributeConnectionTimeout)

Otherwise, looks good to me. Thanks.


> ODBC: Add support for SQL_ATTR_CONNECTION_TIMEOUT
> -------------------------------------------------
>
>                 Key: IGNITE-6876
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6876
>             Project: Ignite
>          Issue Type: Improvement
>          Components: odbc
>    Affects Versions: 2.1
>            Reporter: Alexey Popov
>            Assignee: Igor Sapego
>             Fix For: 2.4
>
>
> Remote ODBC client should be able to request a timeout for socket 
> send/receive operations. It should be done with 
> {{SQL_ATTR_CONNECTION_TIMEOUT}} attribute.
> If an application with ODBC driver experiences a timeout for some query, it 
> can continue to work after closing the connection and establishing a new one.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to