[
https://issues.apache.org/jira/browse/IGNITE-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259051#comment-16259051
]
Evgenii Zhuravlev commented on IGNITE-6745:
-------------------------------------------
[~cossack5], I have a couple of comments for this PR:
1. I don't see Java9Bridge in this pull request, could you please add it?
2. Please check coding guidelines here:
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines. Several
imports from the same package shouldn't be replaced with import package.*.
3. When you remove a field, please remove the whole string and comment for
it(i.e. ClassesGenerator.java 74).
4. Imports should be in alphabetical order.
5. Redundant empty lines(i.e. IgniteCompatibilityAbstractTest.java 174)
Also, how do you resolve a problem with building Ignite with both java7-8 and
java9? I think here should be some changes with maven, but I don't see it.
Thanks,
Evgenii
> Java 9: rework usages of URLClassLoader.getURLs()
> -------------------------------------------------
>
> Key: IGNITE-6745
> URL: https://issues.apache.org/jira/browse/IGNITE-6745
> Project: Ignite
> Issue Type: Task
> Components: general
> Reporter: Vladimir Ozerov
> Fix For: 2.4
>
> Attachments: IGNITE-6745.patch
>
>
> We use this method in multiple places:
> 1) {{MessageCodeGenerator}}
> 2) {{BinaryContext}}
> 3) {{ClassesGenerator}}
> 4) {{GridUriDeploymentFileProcessor}}
> The problem is that in Java 9 application class loader is not
> {{URLClassLoader}}, so we cannot get URLs easily. Instead typically it is
> {{BuiltinClassLoader}}, which refers to {{URLClassLoader}} in it's internal
> field {{ucp}}.
> Let's refactor all usages of {{URLClassLoader.getURLs}} to some utility
> method, which will be able to handle both Java 7/8 and Java 9 (through
> reflection).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
