[
https://issues.apache.org/jira/browse/IGNITE-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251472#comment-16251472
]
Alexey Popov commented on IGNITE-6896:
--------------------------------------
[~ptupitsyn] looks good for me.
One minor comment:
It makes sense to change square 2x2, 2x2x2 arrays to rectangular ones at unit
tests.
It would better verify {{private static int[] GetIndices(int globalIdx, int[]
lengths)}} and index distibution logic.
so please change
{code:java}
int[,] ints = {{1, 2}, {3, 4}};
uint[,,] uints = {{{1, 2}, {3, 4}}, {{5, 6}, {7, 8}}};
{code}
to
{code:java}
int[,] ints = new int[2,3] { { 1, 2, 3 }, { 4, 5, 6 } };
uint[,,] uints = new uint [2,3,1] { { {1}, {2}, {3} }, { {4}, {5},
{6} } };
{code}
> .NET: support Multidimensional Arrays in binary serializer
> ----------------------------------------------------------
>
> Key: IGNITE-6896
> URL: https://issues.apache.org/jira/browse/IGNITE-6896
> Project: Ignite
> Issue Type: Bug
> Security Level: Public(Viewable by anyone)
> Components: platforms
> Affects Versions: 2.3
> Reporter: Alexey Popov
> Assignee: Pavel Tupitsyn
> Labels: .NET
> Fix For: 2.4
>
>
> It is found that legacy 2D, 3D, etc. are not working in BinarySerializer.
> Sample reproducer:
> {code:java}
> [Test]
> public void TestXX()
> {
> var array2D = new float[32, 32];
> var res = TestUtils.SerializeDeserialize(array2D);
> Assert.AreEqual(array2D, res);
> }
> {code}
> BTW, please note that 2D array in Java (a[2][2]) is just a jugged array:
> {noformat}
> obj = {byte[2][]@1928}
> 0 = {byte[2]@1974}
> 1 = {byte[2]@1975}
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
