[
https://issues.apache.org/jira/browse/IGNITE-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249447#comment-16249447
]
Sergey Kalashnikov commented on IGNITE-6850:
--------------------------------------------
[~kirill.shirokov], I have reviewed the changes. Overall it looks good, I only
have few minor comments:
1. {{IgniteH2Indexing.tryQueryDistributedSqlFieldsNative()}}
Pretty similar error handling for both Exception and SqlParseException. Please
consider reducing it to a function call.
2. {{AbstractSchemaSelfTest}}
There are 3 {{assertIndex()}} javadocs that have superfluous whitespace before
first @param.
There should be a blank line between function description and first @param.
3. {{DynamicIndexAbstractBasicSelfTest.checkNoIndexIsCreatedForInlineSize()}}
missing {{igniteQryErrorCode }} param in javadoc.
> SQL: integrate index inline size to CREATE INDEX syntax
> -------------------------------------------------------
>
> Key: IGNITE-6850
> URL: https://issues.apache.org/jira/browse/IGNITE-6850
> Project: Ignite
> Issue Type: Task
> Security Level: Public(Viewable by anyone)
> Components: sql
> Reporter: Vladimir Ozerov
> Assignee: Kirill Shirokov
> Fix For: 2.4
>
>
> Index value inline is important optimization which used to minimize amount of
> data page reads when doing index lookup (see {{InlineIndexHelper}}).
> Currently the only way to set it is {{QueryIndex.inlineSize}} property, so it
> cannot be set from SQL command. We need to integrate it to our SQL syntax
> (see {{SqlCreateIndexCommand}}) and make sure it is propagated properly.
> Sample syntax:
> {code}
> CREATE INDEX idx ON tbl(field) INLINE_SIZE 20;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
