[
https://issues.apache.org/jira/browse/IGNITE-5218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237974#comment-16237974
]
Oleg Ignatenko edited comment on IGNITE-5218 at 11/7/17 3:17 PM:
-----------------------------------------------------------------
Example provided for decision trees
([MNISTExample|https://github.com/gridgain/apache-ignite/blob/ignite-5218/examples/src/main/ml/org/apache/ignite/examples/ml/math/trees/MNISTExample.java])
looks sufficiently documented and runs fine on my machine.
Unit tests run successfully on my machine
([DecisionTreesTestSuite|https://github.com/gridgain/apache-ignite/blob/ignite-5218/modules/ml/src/test/java/org/apache/ignite/ml/trees/DecisionTreesTestSuite.java]),
as well as "internal" benchmark
[ColumnDecisionTreeTrainerBenchmark|https://github.com/gridgain/apache-ignite/blob/ignite-5218/modules/ml/src/test/java/org/apache/ignite/ml/trees/performance/ColumnDecisionTreeTrainerBenchmark.java].
Worth noting that yesterday Yury did a [trial run on
TC|https://ci.ignite.apache.org/viewLog.html?buildId=927458&buildTypeId=Ignite20Tests_IgniteMl&tab=buildResultsDiv]
for this pull request and it came out all green.
Code formatting looks right in both main and test parts.
Code inspections results are okay in both main and test parts.
was (Author: oignatenko):
Example provided for decision trees
([MNISTExample|https://github.com/gridgain/apache-ignite/blob/ignite-5218/examples/src/main/ml/org/apache/ignite/examples/ml/math/trees/MNISTExample.java])
looks sufficiently documented and runs fine on my machine.
Unit tests run successfully on my machine
([DecisionTreesTestSuite|https://github.com/gridgain/apache-ignite/blob/ignite-5218/modules/ml/src/test/java/org/apache/ignite/ml/trees/DecisionTreesTestSuite.java]),
as well as "internal" benchmark
[ColumnDecisionTreeTrainerBenchmark|https://github.com/gridgain/apache-ignite/blob/ignite-5218/modules/ml/src/test/java/org/apache/ignite/ml/trees/performance/ColumnDecisionTreeTrainerBenchmark.java].
Worth noting that yesterday Yury did a [trial run on
TC|https://ci.ignite.apache.org/viewLog.html?buildId=927458&buildTypeId=Ignite20Tests_IgniteMl&tab=buildResultsDiv]
for this pull request and it came out all green.
Code formatting looks right in both main and test parts.
Code inspections results for main part are mostly okay, I commented on few
remaining minor issues in pull request. (x) Code inspections for test part are
yet to be fixed.
> Decision trees
> --------------
>
> Key: IGNITE-5218
> URL: https://issues.apache.org/jira/browse/IGNITE-5218
> Project: Ignite
> Issue Type: New Feature
> Components: ml
> Reporter: Yury Babak
> Assignee: Artem Malykh
>
> We want to implement Decision trees for Ignite ML because it's really common
> one for ML.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
