[ 
https://issues.apache.org/jira/browse/IGNITE-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182460#comment-16182460
 ] 

Vladimir Ozerov edited comment on IGNITE-5439 at 9/27/17 12:14 PM:
-------------------------------------------------------------------

[~tledkov-gridgain],
1) JdbcThinConnection.sendRequestThroughNewConnection - do we close new IO?
2) Using (connection ID + query ID) might be not very good idea, because 
malicious client might start closing cursors of other clients - they are very 
easy to guess. May be we should think on adding a kind of UUID to connection ID.
3) JdbcThinConnection.QRY_ID_GEN - you cannot rely on {{currentQUeryId}}, as it 
might be advanced by other opened statements. You should generate ID only once 
and then pass it to statement.
4) New {{IgniteQueryErrorCode.QUERY_CANCELED}} is added, but I do not see if it 
mapped to any SQLSTATE. So what is the point of this vendor-specific code?


was (Author: vozerov):
1) JdbcThinConnection.sendRequestThroughNewConnection - do we close new IO?
2) Using (connection ID + query ID) might be not very good idea, because 
malicious client might start closing cursors of other clients - they are very 
easy to guess. May be we should think on adding a kind of UUID to connection ID.
3) JdbcThinConnection.QRY_ID_GEN - you cannot rely on {{currentQUeryId}}, as it 
might be advanced by other opened statements. You should generate ID only once 
and then pass it to statement.
4) New {{IgniteQueryErrorCode.QUERY_CANCELED}} is added, but I do not see if it 
mapped to any SQLSTATE. So what is the point of this vendor-specific code?

> JDBC thin: support query cancel
> -------------------------------
>
>                 Key: IGNITE-5439
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5439
>             Project: Ignite
>          Issue Type: Task
>          Components: jdbc
>    Affects Versions: 2.0
>            Reporter: Taras Ledkov
>            Assignee: Taras Ledkov
>             Fix For: 2.3
>
>
> The JDBC {{Statement.cancel}} method must be supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to