[
https://issues.apache.org/jira/browse/IGNITE-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181279#comment-16181279
]
Alexander Paschenko commented on IGNITE-6286:
---------------------------------------------
[~schernolyas]
Thanks for fixing p.1.
However, I don't see any changes regarding pts. 2-4.
Pt. 2 - most members of *test* class you added don't have javadocs.
Pt. 3 - this test doesn't have anything to do with Hibernate, JPA, etc. Please
use convenient public Ignite API, this will make test better readable and
understandable, and it's important as we have lot of people working on the
project.
Pt. 4 - I don't see any code deduplication you've made. Please look at your
methods {{testStringSupport}}, {{testIntegerSupport}}, etc - they all are
almost identical, copy-pasted. It would be much simpler if you just made one
test method that would check all fields inside of it.
Also, please don't create any more PRs, Ignite policy is one PR per issue. Just
push your commits with fixes to the same branch.
Thanks!
> org.h2.jdbc.JdbcSQLException: Hexadecimal string with odd number of characters
> ------------------------------------------------------------------------------
>
> Key: IGNITE-6286
> URL: https://issues.apache.org/jira/browse/IGNITE-6286
> Project: Ignite
> Issue Type: Bug
> Components: sql
> Affects Versions: 2.1
> Reporter: Sergey Chernolyas
> Assignee: Sergey Chernolyas
> Labels: usability
> Fix For: 2.3
>
>
> Binding values of some types to parameterized queries leads to the exception
> (see fill stacktrace in comments).
> Also, the exception *blocks* using parameterized queries for Hibernate OGM.
> I proceed the exception for String type. For control it, I developed test (
> see
> org.apache.ignite.internal.processors.query.IgniteSqlParameterizedQueryTest)
> .
> The exception reproduced for BigDecimal type in 2.3-snapshot.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
