[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166170#comment-16166170
]
Pavel Tupitsyn commented on IGNITE-5097:
----------------------------------------
[~daradurvs]:
1) Make sure code lines fit within 120 chars (BinaryConfiguration,
BinaryObjectBuilder, etc)
2) Method comments should be in "///" format, not "/**" (BinaryUtils). I know
there is some old code with wrong format, but all new/updated methods should
have proper format.
3) Unused import in BinaryEqualityComparerTest
4) Could not compile Java (mvn clean package):
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile
(default-testCompile) on project ignite-indexing: Compilation failure: Compilat
ion failure:
[ERROR]
/C:/w/incubator-ignite/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicColumnsAbstractBasicSelfTest.java:[272,13]
reference
to assertEquals is ambiguous
[ERROR] both method assertEquals(java.lang.Object,java.lang.Object) in
junit.framework.TestCase and method assertEquals(int,int) in
junit.framework.TestCase match
[ERROR]
/C:/w/incubator-ignite/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicColumnsAbstractBasicSelfTest.java:[275,13]
reference
to assertEquals is ambiguous
[ERROR] both method assertEquals(java.lang.Object,java.lang.Object) in
junit.framework.TestCase and method assertEquals(int,int) in
junit.framework.TestCase match
{code}
Other than that - good job!
> BinaryMarshaller should write ints in "varint" encoding where it makes sense
> ----------------------------------------------------------------------------
>
> Key: IGNITE-5097
> URL: https://issues.apache.org/jira/browse/IGNITE-5097
> Project: Ignite
> Issue Type: Task
> Components: general
> Affects Versions: 2.0
> Reporter: Vladimir Ozerov
> Assignee: Vyacheslav Daradur
> Labels: important, performance
> Fix For: 2.3
>
>
> There are a lot of places in the code where we write integers for some
> special purposes. Quite often their value will be vary small, so that
> applying "varint" format could save a lot of space at the cost of very low
> additional CPU overhead.
> Specifically:
> 1) Array/collection/map lengths
> 2) BigDecimal's (usually will save ~6 bytes)
> 3) Strings
> 4) Enum ordinals
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
