[
https://issues.apache.org/jira/browse/IGNITE-5551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091557#comment-16091557
]
ASF GitHub Bot commented on IGNITE-5551:
----------------------------------------
GitHub user kukushal opened a pull request:
https://github.com/apache/ignite/pull/2314
IGNITE-5551 Optimize service deployment assignments object
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-gg-5551
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/2314.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2314
----
commit 52b6f7d6402cb23f2f5565e98b4a924dc7e82ee4
Author: Alexey Kukushkin <[email protected]>
Date: 2017-07-11T16:38:28Z
a test for IGNITE-5551
commit c7825365fd70d4b5fc80bc53dd734109b8f6a50f
Author: Alexey Kukushkin <[email protected]>
Date: 2017-07-12T16:30:42Z
some progress on IGNITE-5551
commit 93530d259bae76ed2106d8cccad82c1377c92636
Author: Alexey Kukushkin <[email protected]>
Date: 2017-07-13T10:29:12Z
some progress
commit a35381cf8cec743c750499156d1f89b559d68859
Author: Alexey Kukushkin <[email protected]>
Date: 2017-07-13T17:02:43Z
new design for IGNITE-5551 solution
commit 356fef37c09c899b6be240ff5eb3c42f71693e8e
Author: Alexey Kukushkin <[email protected]>
Date: 2017-07-13T21:06:20Z
small progress
commit 5c3839c50001ee4612f7e477a95ac5dc1095cbe0
Author: Alexey Kukushkin <[email protected]>
Date: 2017-07-14T13:34:11Z
Java changes complete
commit 219f28948d22a36f9292ae34b02e18171486d3cc
Author: oleg-ostanin <[email protected]>
Date: 2017-07-17T13:29:16Z
removed excluding ML sources from assembly file - Fixes #2310.
Signed-off-by: Alexey Goncharuk <[email protected]>
commit e88fcd8d228e2f15187ff05218f3afb242c65fed
Author: devozerov <[email protected]>
Date: 2017-07-17T14:13:16Z
Revert "removed excluding ML sources from assembly file - Fixes #2310."
This reverts commit 219f28948d22a36f9292ae34b02e18171486d3cc.
commit 757a301a08942b14a0efeb29837b09a424ffe2a9
Author: Alexey Kukushkin <[email protected]>
Date: 2017-07-17T17:14:33Z
Merge remote-tracking branch 'gridgain/ignite-2.1.2' into ignite-gg-5551
----
> Optimize service deployment assignments object
> ----------------------------------------------
>
> Key: IGNITE-5551
> URL: https://issues.apache.org/jira/browse/IGNITE-5551
> Project: Ignite
> Issue Type: Improvement
> Components: managed services
> Affects Versions: 1.7
> Reporter: Alexey Goncharuk
> Assignee: Alexey Kukushkin
> Priority: Critical
> Fix For: 2.2
>
>
> 1) The deployment assignment is stored using a map [node ID -> number of
> assigned services]. However, this assignment is not very effective for cases
> when service configuration is (maxPerCluster = 0, maxPerNode > 0), because in
> this case, we can avoid assignment recalculation at all. The assignment for
> this case may look like (eachNode=N). In this case, the assignment does not
> change and we can effectively skip it during the reassign loop.
> 2) We store zero assignment counters, which does not make sense at all - if
> there are no service deployments for a node, there should be no corresponding
> entry in the map at all. The size of assignments for (maxPerCluster > 0)
> configurations is O(number of nodes in the cluster), but it should be
> O(maxPerCluster).
> 3) If an assignment did not change, we should not commit the assignment
> transaction - this is redundant
> 4) Perhaps, it also makes sense to calculate several assignments at once and
> do a putAll commit instead of single puts - this should also decrease the
> assignment calculation latency
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
