[ 
https://issues.apache.org/jira/browse/IGNITE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032923#comment-16032923
 ] 

Vladimir Ozerov commented on IGNITE-5327:
-----------------------------------------

[~al.psc], in general fix looks good, but I would add several usability 
improvements:
1) Let's use {{PARTITIONED}} template by default if {{template}} parameter is 
not provided at all. This is precisely how {{Ignite.createCache(new 
CacheConfiguration())}} works. Additional tests are needed for this.
2) Let's perform case insensitive comparison for {{PARTITIONED}} and 
{{REPLICATED}} caches. This way both {{template=PARTITIONED}} and 
{{template=partitioned}} will work.

> Create predefined cache templates for CREATE TABLE command
> ----------------------------------------------------------
>
>                 Key: IGNITE-5327
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5327
>             Project: Ignite
>          Issue Type: Task
>          Components: sql
>            Reporter: Vladimir Ozerov
>            Assignee: Alexander Paschenko
>             Fix For: 2.1
>
>
> We need to add predefined templates which will always be available on the 
> node. Let's avoid adding them to node configuration to avoid cache data 
> sharing on node startup. Instead, let's just create them on-fly when certain 
> template name is found.
> Proposed templates:
> 1) "PARTITIONED" => {{new CacheConfiguration().setCacheMode(PARTITIONED)}}
> 2) "REPLICATED" => {{new CacheConfiguration().setCacheMode(REPLICATED)}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to