[ 
https://issues.apache.org/jira/browse/IGNITE-5040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986619#comment-15986619
 ] 

ASF GitHub Bot commented on IGNITE-5040:
----------------------------------------

GitHub user ybabak opened a pull request:

    https://github.com/apache/ignite/pull/1881

    IGNITE-5040 ML examples:

      restored missed changes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-5040

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1881.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1881
    
----
commit bbd31ca54bfc4341248c79b35890e012db975821
Author: Yury Babak <[email protected]>
Date:   2017-04-27T13:27:49Z

    IGNITE-5040 ML examples:
      restored missed changes

----


> ML examples
> -----------
>
>                 Key: IGNITE-5040
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5040
>             Project: Ignite
>          Issue Type: Bug
>          Components: ml
>    Affects Versions: 2.0
>            Reporter: Sergey Kozlov
>            Assignee: Yury Babak
>             Fix For: 2.0
>
>
> I've reviewed examples for ML module and found some issues:
> 1. There's no description for examples at beginning of code (as we've for 
> other java examples)
> 2. TracerExample opens the empty HTML page (seems JS error)
> 3. Example isn't a test and shouldn't have asserts. Correctness of example 
> results is responsibility of tests.
> 4. Some local API calls used without running Ignite nodes would be better to 
> provide as part of remote jobs sent to the cluster



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to