[ 
https://issues.apache.org/jira/browse/IGNITE-4760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976827#comment-15976827
 ] 

ASF GitHub Bot commented on IGNITE-4760:
----------------------------------------

GitHub user vadopolski reopened a pull request:

    https://github.com/apache/ignite/pull/1841

    Ignite 4760#1084

    - added AccessType parameter in 'threadLocalForCache' 
    - merge HibernateL2CacheNonStrictReadWriteSelfTest and 
HibernateL2CacheReadWriteSelfTest to HibernateL2CacheStrategySelfTest
    - tested with fix of isue IGNITE-4760
    - checked that HibernateL2CacheSelfTest#testNaturalIdCache() did not fail 
after fix IGNITE-4760

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vadopolski/ignite ignite-4760#1084

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1841.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1841
    
----
commit 7f8db35b72bf8dae633579394c79a6e07781da8d
Author: vadopolski <[email protected]>
Date:   2017-04-04T16:56:34Z

    Added test

commit 394e5e53ab225b5cb9d43866617ab8cf1f056bcc
Author: vadopolski <[email protected]>
Date:   2017-04-05T11:16:38Z

    Added update for another region.

commit f2f31a681f872d6f04dd92d3006f008b463939c8
Author: vadopolski <[email protected]>
Date:   2017-04-05T11:55:28Z

    Added update for another region.

commit 579d106005ad03d423a13133567f17587c857320
Author: vadopolski <[email protected]>
Date:   2017-04-05T12:00:17Z

    Added update for another region.

commit 01a4f721a6955fb3e1d92dbf2716b6e04519f7a7
Author: vadopolski <[email protected]>
Date:   2017-04-05T12:12:32Z

    Added update for another region.

commit 7767a85875d0d0c0878b49f02086a50a9a15f7d2
Author: vadopolski <[email protected]>
Date:   2017-04-05T12:15:10Z

    Added update for another region.

commit a4d7d7fd126d42b97cd06cd6df9d3a172a0519f4
Author: vopolski <2w3e4r5t>
Date:   2017-04-10T14:00:13Z

    Added failed test with adding, updating cache.

commit f51ed5c30fa345f308c148794566a8d7515a3dec
Author: vopolski <2w3e4r5t>
Date:   2017-04-10T14:23:59Z

    Fixed method threadLocalForCache  per-cache thread local.

commit bfcaf05f69594455550fceb961e50911cdc9d75d
Author: vopolski <2w3e4r5t>
Date:   2017-04-10T14:26:42Z

    Fixed method threadLocalForCache  per-cache thread local.

commit e6f189e67c7cef30bcd4377aeeab5e8f731d1323
Author: vopolski <2w3e4r5t>
Date:   2017-04-10T14:28:32Z

    IGNITE-4760
    Fixed method threadLocalForCache  per-cache thread local.

commit 9ed28171716dcd00a8db56cebd50bc5c168c72ce
Author: vopolski <2w3e4r5t>
Date:   2017-04-10T16:25:14Z

    IGNITE-4760
    threadLocalMap changed to ConcurrentHashMap.

commit c654f620ce3b0c3cc733984f53902f9c3a174272
Author: vopolski <2w3e4r5t>
Date:   2017-04-10T16:55:05Z

    IGNITE-4760
    threadLocalMap changed to ConcurrentHashMap.

commit 032736066c71941010972935298c06a636db0ff2
Author: vopolski <2w3e4r5t>
Date:   2017-04-14T14:00:44Z

    IGNITE-4760
    Added HibernateL2CacheNonStrictReadWriteSelfTest and 
HibernateL2CacheReadWriteSelfTest.

commit 18413375a49430de8af1c28c484a81211b02f45f
Author: vopolski <2w3e4r5t>
Date:   2017-04-14T14:12:06Z

    IGNITE-4760
    code style issues: do not use wildcard improrts and 'finally' should be on 
next line after '}'

commit ded2a8dd7f3305130a24f36b9f52cf6f8edb69b6
Author: vopolski <2w3e4r5t>
Date:   2017-04-14T17:00:01Z

    IGNITE-4760
    check access type for created region

commit f56d748c2e23719747c1a8ad0ab725ede70b220c
Author: vopolski <2w3e4r5t>
Date:   2017-04-19T12:04:08Z

    IGNITE-4760
    Added new tests to IgniteHibernateTestSuite.

commit da305e85a140b00c0c3963173bd7149bf03cd80b
Author: vopolski <2w3e4r5t>
Date:   2017-04-19T12:10:41Z

    IGNITE-4760
    Changed name of new tests.

commit 14bf2fa40f47c5d66617a5038f78b7640ecafdd9
Author: vopolski <2w3e4r5t>
Date:   2017-04-20T08:23:06Z

    IGNITE-4760 IGNITE-1084
    Tests NaturalCacheID is not failed.

commit 21218d0e98a109a58a3e59e162e46b38b307977c
Author: vopolski <2w3e4r5t>
Date:   2017-04-20T13:46:28Z

    IGNITE-4760 IGNITE-1084
    - added AccessType parameter in 'threadLocalForCache'
    - merge HibernateL2CacheNonStrictReadWriteSelfTest and 
HibernateL2CacheReadWriteSelfTest to HibernateL2CacheStrategySelfTest
    - tested with fix of isue IGNITE-4760
    - checked that HibernateL2CacheSelfTest#testNaturalIdCache() did not fail 
after fix IGNITE-4760

commit 34cddf09ed5ef8f8f3eccf35b59b8bb7adb92716
Author: vopolski <2w3e4r5t>
Date:   2017-04-20T14:02:48Z

    IGNITE-4760 IGNITE-1084
    - added AccessType parameter in 'threadLocalForCache'
    - merge HibernateL2CacheNonStrictReadWriteSelfTest and 
HibernateL2CacheReadWriteSelfTest to HibernateL2CacheStrategySelfTest
    - tested with fix of isue IGNITE-4760
    - checked that HibernateL2CacheSelfTest#testNaturalIdCache() did not fail 
after fix IGNITE-4760

----


> Hibernate L2 cache stores value in wrong cache
> ----------------------------------------------
>
>                 Key: IGNITE-4760
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4760
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: Hibernate L2 cache
>            Reporter: Semen Boikov
>            Assignee: Vadim Opolski
>             Fix For: 2.1
>
>
> Issue is reported here:
> http://apache-ignite-developers.2346864.n4.nabble.com/issue-with-Hibernate-2L-cache-region-factory-ignite-1-8-td14912.html
> First it is necessary add JUnit test reproducing issue (see existing tests in 
> IgniteHibernateTestSuite).
> Currently Hibernate access strategies track updates using thread locals, and 
> it looks like updates for different caches can be mixed. I think per-cache 
> thread local can fix issue for HibernateNonStrictAccessStrategy, but 
> per-cache thread local can not be used for HibernateReadWriteAccessStrategy, 
> since it is assumed that all updates should be part of the same cross-cache 
> ignite transaction.
> So possible fix:
> - use per-cache thread local for HibernateNonStrictAccessStrategy (or somehow 
> track target cache in HibernateNonStrictAccessStrategy)
> - use single thread local for HibernateReadWriteAccessStrategy



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to