[ 
https://issues.apache.org/jira/browse/IGNITE-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974355#comment-15974355
 ] 

ASF GitHub Bot commented on IGNITE-5001:
----------------------------------------

GitHub user ptupitsyn opened a pull request:

    https://github.com/apache/ignite/pull/1827

    IGNITE-5001 .NET: Tests cleanup

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ptupitsyn/ignite ignite-5001

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1827.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1827
    
----
commit 549b683d8b46970b161f6264a70e221e66ce0c9a
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T10:41:15Z

    BinaryUtils cleanup

commit 5f8382c8b30f512ef06206632f6c64228911e2f2
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T12:29:26Z

    Merge branch 'master' into ignite-5001

commit 7169873a47f66a16d0fe8cd437322c52bd47c9b8
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T12:44:29Z

    Remove unused imports

commit 6c4ddbe88a811f9c8208c2c41d57a3302f706887
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T13:04:17Z

    Merge branch 'master' into ignite-5001

commit df34e4830588cdeb0bb3609fe6fc67b6294a519a
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T13:41:07Z

    wip

commit a41eac6c63e7a16e6a1a82c9571d11e556d7f3fb
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T13:42:05Z

    wip

commit f045c6d7899d97a89a1d53c61a929fc9ba3a8dff
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:00:13Z

    wip

commit 2f5852e297d9c6519c37ecfcd6e2a1c3fade45ae
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:00:47Z

    wip

commit 36dc7a2f56b6bbf132095dbe7b30a090eb54c1f2
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:02:36Z

    wip

commit 308ca9d264a67334ef518f2cb5a1df4e39f36e4d
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:07:25Z

    wip

commit b032dc0be392fc66cc4a10529e67f4c7bcab1477
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:18:02Z

    wip

commit 59b063142f592249b25e6160a63415d9fe8f41af
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:18:39Z

    wip

commit 62c082eb38c24f04f9b854420d1c81985a5e382a
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:21:19Z

    wip

commit ef7694c7a21e4d181fc440b94dbdda50e1de007e
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:24:12Z

    wip

commit 8bed87598b2624f08b8e2d17a4fcf1e2199c2ad2
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:26:55Z

    wip

commit c5e0ad676e1f28fb3dabccea8f83c6d66e6f18a5
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:27:46Z

    wip

commit 5c53b9749a9cd5480edbfa16cde5158ff3a98ad3
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:28:34Z

    wip

commit 4bf28a3dd01717423490f6401105d64d7316fc71
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:31:23Z

    wip

commit c2c9a12dd5b5614e14127613e43c507c9adce483
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:38:34Z

    wip

commit eeffa38b060f879f1279090542cfa04234981668
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:42:10Z

    wip

commit f14f7a39a44fec4f61f4e350f20f8a04c1842375
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:43:38Z

    wip

commit 2a723fb03ab5bf6dbd6ada5ecec1d575c0085b36
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:54:49Z

    wip

commit d121d4f0c688d081d8e879971ca31449d7eea579
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T14:57:42Z

    wip

commit 39218dcf1ee71176dfe050c2302ce62fdc91e163
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T15:02:06Z

    wip

commit 712556956edca2960a2987c3c077ede6c8abf194
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T15:03:59Z

    wip

commit 3889104717ea7e10d0d79f77facda7ed3db788f6
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T15:09:28Z

    wip

commit 203a4ed446b548f9cf14099b56edec3af13a2506
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T15:14:12Z

    wip

commit 0668b7d74f144264a890528d38238a2cee1bba77
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T15:14:38Z

    wip

commit 98545e96eb22a4f0091a1f1affdbf28602aa4d70
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T15:18:26Z

    wip

commit c2e3845f42fa4d0e65ab559a7d87e20852be31c5
Author: Pavel Tupitsyn <[email protected]>
Date:   2017-04-18T15:19:35Z

    wip

----


> .NET: Tests cleanup
> -------------------
>
>                 Key: IGNITE-5001
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5001
>             Project: Ignite
>          Issue Type: Improvement
>          Components: platforms
>            Reporter: Pavel Tupitsyn
>            Assignee: Pavel Tupitsyn
>            Priority: Trivial
>             Fix For: 2.1
>
>
> * Use {{GetTestConfiguration}} where possible
> * Make sure {{Localhost}} is set in all other cases to avoid external node 
> discovery
> * Remove binary type configuration where it is not necessary
> * Get rid of Spring XML where it is not needed (Events, Messaging, etc)
> * Replace try-catch with {{Assert.Throws}} where possible
> * Make sure {{Ignition.StopAll}} is present where needed



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to