[ 
https://issues.apache.org/jira/browse/IGNITE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967156#comment-15967156
 ] 

Pavel Tupitsyn commented on IGNITE-3581:
----------------------------------------

[~isapego] I like the change from {{IGNITE_TX_STATE_MARKED_ROLLBACK}} to 
{{TransactionState::MARKED_ROLLBACK}}, easier to read and to write.

But is it common to place enum inside struct to achieve this?

> CPP: Place different enums and constants in separate namespaces or structs.
> ---------------------------------------------------------------------------
>
>                 Key: IGNITE-3581
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3581
>             Project: Ignite
>          Issue Type: Task
>          Components: platforms
>    Affects Versions: 1.6
>            Reporter: Igor Sapego
>            Assignee: Igor Sapego
>              Labels: cpp
>             Fix For: 2.0
>
>
> The common practice is to place enums and constants in separate namespaces or 
> structs. This way we can group them and avoid name clashes without the need 
> to use long names.
> [Details|http://stackoverflow.com/questions/7090130/enum-in-a-namespace].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to