[
https://issues.apache.org/jira/browse/IGNITE-4799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963322#comment-15963322
]
Denis Magda edited comment on IGNITE-4799 at 4/10/17 6:42 PM:
--------------------------------------------------------------
[~yzhdanov], thanks for taking care of this. Please see below:
1. I've updated Javadoc of {{IgniteConfiguration.metricsUpdateFrequency}}
parameter and merged the changes to the branch provided by you. This is enough
for now. As for the readme.io doc, just assign the ticket to me once the
changes are merged.
2. Let's remove it. As I see it was used in a combination with
{{TcpDiscoverySpi.heartbeatsFrequency}}. The latter is no longer exists and
looks like {{TcpDiscoverySpi.maxMissedHeartbeats}} can be wiped out right away.
3. Yes, I would rename existing properties to avoid confusion. However, if it
might take extra time then let's merge current breaking changes into 2.0 and
keep the rest of refactoring in 2.1. What do you think?
was (Author: dmagda):
[~yzhdanov], thanks for taking care of this. Please see below:
1. I've updated Javadoc of {{IgniteConfiguration.metricsUpdateFrequency}}
parameter. This is enough for now. As for the readme.io doc, just assign the
ticket to me once the changes are merged.
2. Let's remove it. As I see it was used in a combination with
{{TcpDiscoverySpi.heartbeatsFrequency}}. The latter is no longer exists and
looks like {{TcpDiscoverySpi.maxMissedHeartbeats}} can be wiped out right away.
3. Yes, I would rename existing properties to avoid confusion. However, if it
might take extra time then let's merge current breaking changes into 2.0 and
keep the rest of refactoring in 2.1. What do you think?
> Remove TcpDiscoverySpi.heartbeatsFrequency parameter
> ----------------------------------------------------
>
> Key: IGNITE-4799
> URL: https://issues.apache.org/jira/browse/IGNITE-4799
> Project: Ignite
> Issue Type: Bug
> Reporter: Denis Magda
> Assignee: Alexander Belyak
> Labels: important
> Fix For: 2.0
>
>
> {{TcpDiscoverySpi.heartbeatsFrequency}} is no longer used to adjust the
> heartbeats frequence. It affects the frequency of metrics messages sent over
> the cluster ring.
> The following has to be done as a part of 2.0 release:
> * Remove {{TcpDiscoverySpi.heartbeatsFrequency}} parameter.
> * Use {{IgniteConfiguraion.getMetricsUpdateFrequency}} to adjust the rate of
> metrics messages.
> * Make sure {{IgniteConfiguraion.getMetricsUpdateFrequency}} and metrics
> messages are not participated in the failure detection process. We have to
> clean up legacy code in {{ServerImpl}}.
> Refer to this discussion for more details:
> http://apache-ignite-developers.2346864.n4.nabble.com/Renaming-TcpDiscoverySpi-heartbeatsFrequency-to-TcpDiscoverySpi-metricsUpdateFrequency-td14941.html
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
