[
https://issues.apache.org/jira/browse/IGNITE-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892144#comment-15892144
]
ASF GitHub Bot commented on IGNITE-4770:
----------------------------------------
GitHub user daradurvs opened a pull request:
https://github.com/apache/ignite/pull/1586
IGNITE-4770
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daradurvs/ignite ignite-4770
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/1586.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1586
----
commit ce3b7dab3aeeeca9e5f0357ab80309ecf75999ab
Author: Vyacheslav Daradur <[email protected]>
Date: 2017-03-02T12:24:32Z
ignite-4770: workaround solution
----
> Script inside javadoc bottom cause compilation error at 1.8.0_121-b13
> ---------------------------------------------------------------------
>
> Key: IGNITE-4770
> URL: https://issues.apache.org/jira/browse/IGNITE-4770
> Project: Ignite
> Issue Type: Bug
> Reporter: Anton Vinogradov
> Assignee: Vyacheslav Daradur
> Fix For: 2.0
>
>
> Problem:
> parent/pom.xml:455 contains following:
> {noformat}
> <script>!function(d,s,id){var
> js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+'://platform.twitter.com/widgets.js';fjs.parentNode.insertBefore(js,fjs);}}(document,
> 'script', 'twitter-wjs');</script>
> {noformat}
> this script generates "Follow us" at the bottom of the
> incubator-ignite/target/javadoc/core/index.html.
> this cause compilation error during
> {noformat}
> mvn clean package -DskipTests
> {noformat}
> error
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:2.10.1:jar (module-javadoc) on
> project ignite-tools: MavenReportException: Error while creating archive:
> [ERROR] Exit code: 1 - javadoc: error - Argument for -bottom contains
> JavaScript.
> [ERROR] Use --allow-script-in-comments to allow use of JavaScript.
> {noformat}
> addition of "--allow-script-in-comments"
> cause compilation issues on any JDK8 before 1.8.0_121-b13
> {noformat}
> [ERROR] Failed to execute goal org.apache.maven.plugins:
> maven-javadoc-plugin:2.10.1:jar (module-javadoc) on project ignite-tools:
> MavenReportException: Error while creating archive:
> [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> --allow-script-in-comments
> {noformat}
> Solution:
> Need to keep button at the bottom of the page, but fix compilation errors.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
