[
https://issues.apache.org/jira/browse/IGNITE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Ozerov reassigned IGNITE-4558:
---------------------------------------
Assignee: Evgenii Zhuravlev (was: Vladimir Ozerov)
[~ezhuravl], my comments:
1) Please see my minor corrections.
2) From now on we never use {{Object.hashCode()}}. This is expected change, but
I think we should also apply this idea to {{BinaryObjectBuilder}} and disallow
setting hash code by hand. Let's remove {{BinaryObjectBuilder.hashCode}} method
and see if other parts of Ignite (especially DML) work fine. Also this should
simplify {{BinaryClassDescriptor.postWrite}} method a lot.
> Use BinaryArrayIdentityResolver by default
> ------------------------------------------
>
> Key: IGNITE-4558
> URL: https://issues.apache.org/jira/browse/IGNITE-4558
> Project: Ignite
> Issue Type: Improvement
> Components: binary
> Reporter: Pavel Tupitsyn
> Assignee: Evgenii Zhuravlev
> Priority: Critical
> Fix For: 2.0
>
>
> Currently if there is no configured
> {{BinaryTypeConfiguration.IdentityResolver}}, we call Object.hashCode().
> This is not consistent with DML, and there is a warning:
> {code}
> Binary object's type does not have identity resolver explicitly set,
> therefore BinaryArrayIdentityResolver is used to generate hash codes for its
> instances, and therefore hash code of this binary object will most likely not
> match that of its non serialized form. For finer control over identity of
> this type, please update your BinaryConfiguration accordingly.
> {code}
> In 2.0 we should use {{BinaryArrayIdentityResolver}} by default.
> 2.0 migration guide has to be updated if needed:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
