[ 
https://issues.apache.org/jira/browse/IGNITE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813392#comment-15813392
 ] 

Denis Magda edited comment on IGNITE-2422 at 1/10/17 12:53 AM:
---------------------------------------------------------------

Maksim, I was wrong initially. We do support serialization and deserialization 
of {{BinaryObjectBuilder}}. Having a more deep look I found our that the test 
fails due to deserialization related issue. In general, if we add the following 
two lines

{code}
org.apache.ignite.binary.BinaryObjectBuilder
org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl
{code}

to {{META-INF/classnames.properties}} file then the attached tests will pass 
without issue.

The issue is that I can't update this file to the latest state automatically.
[~avinogradov], [~vozerov], I've tried to build the project from scratch but 
both {{BinaryObjectBuilder}} and {{BinaryObjectBuilderImpl}} were not added to 
the classnames.properties. Even more I've downloaded 1.8 versions and there is 
no {{META-INF/classnames.properties}} file at all. Did we break something or 
the logic has changed?


was (Author: dmagda):
Maksim, I was wrong initially. We do support serialization and deserialization 
of {{BinaryObjectBuilder}}. Having a more deep look I found our that the test 
fails due to deserialization related issue. In general, if we add the following 
two lines

{code}
org.apache.ignite.binary.BinaryObjectBuilder
org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl
{code}

to {{META-INF/classnames.properties}} file than the attached tests will pass 
without issue.

The issue is that this file has to be updated to the latest state. However, 
also I see that this file no longer delivered in Ignite releases which looks 
like a broken functionality.

[~avinogradov], [~vozerov], I've tried to build the project from scratch but 
both {{BinaryObjectBuilder}} and {{BinaryObjectBuilderImpl}} were not added to 
the classnames.properties. Even more I've downloaded 1.8 versions and there is 
no {{META-INF/classnames.properties}} file at all. Did we break something or 
the logic has changed?

> Prevent serialization of BinaryObjectBuilder
> --------------------------------------------
>
>                 Key: IGNITE-2422
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2422
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 1.5.0.final
>            Reporter: Denis Magda
>            Assignee: Maksim Kozlov
>              Labels: important
>             Fix For: 2.0
>
>         Attachments: ExampleNodeStartup.java
>
>
> Presently it's possible to serialize {{BinaryObjectBuilder}} but it will lead 
> to the errors at deserialization stage.
> We have to prevent serialization of the builder throwing a meaningful 
> exception.
> Run an example from attach and you will see an exception that is caused by 
> the serialization/deserialization of the builder.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to