[
https://issues.apache.org/jira/browse/IGNITE-29161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Chesnokov updated IGNITE-29161:
-----------------------------------------
Description: This is an idea from the earlier plan under IGNITE-25489.
Generated JSON describes message structure, but a change in serialization code
can affect the bytes without changing that structure. A code hash could help
make such changes visible. Before implementation, agree which code the hash
should cover and how reviewers should use it. This work needs a separate scope
decision and is not a prerequisite for IGNITE-29261 or IGNITE-29145. The
current plan generates descriptions in CI rather than committing {{wire/}}
files. (was: The JSON files in {{wire/}} show only the fields of a message. If
a constructor or a method of a message class changes, the bytes on the wire can
change, but the files stay the same. Let's add a hash of the class code to
every JSON file, so such a change is visible in the pull request diff too.)
> Add a code hash to message JSON files
> -------------------------------------
>
> Key: IGNITE-29161
> URL: https://issues.apache.org/jira/browse/IGNITE-29161
> Project: Ignite
> Issue Type: Improvement
> Reporter: Aleksandr Chesnokov
> Assignee: Aleksandr Chesnokov
> Priority: Major
>
> This is an idea from the earlier plan under IGNITE-25489. Generated JSON
> describes message structure, but a change in serialization code can affect
> the bytes without changing that structure. A code hash could help make such
> changes visible. Before implementation, agree which code the hash should
> cover and how reviewers should use it. This work needs a separate scope
> decision and is not a prerequisite for IGNITE-29261 or IGNITE-29145. The
> current plan generates descriptions in CI rather than committing {{wire/}}
> files.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
