[
https://issues.apache.org/jira/browse/IGNITE-29208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132681#comment-18132681
]
Anton Vinogradov commented on IGNITE-29208:
-------------------------------------------
[Ignite PR Checker|https://ignite-pr-checker.is-a.dev/?pr=13750] verdict for PR
13750 · RunAll build [9445198|https://ci2.ignite.apache.org/build/9445198] ·
tested
[7a2076b|https://github.com/apache/ignite/pull/13750/commits/7a2076b65b142fc0eb441871f65c5b698b2a7ce7]
· 149 suites ran, 0 reused
(!) *This run doesn't cover the PR fully:*
- 1 suite ran fewer tests than the same suite on master
Everything below is what it did manage to say.
(?) *1 suite ran fewer tests than on master* (tests that never ran can't fail):
- Cache 1: ran 530 of master's 605 tests (*-12%*)
(?) *No blockers found — but the run above can't prove the PR is clean.* 20
failing tests are not blamed on this PR. Re-run after you handle what is listed
above.
_What each label means and what to do: [verdict
glossary|https://github.com/anton-vinogradov/ignite-pr-checker/blob/main/docs/features.md#verdict-glossary]._
♻️ Settled after 2 auto re-run waves: #1 — 4 suites that failed mid-run; #2 — 1
broken suite.
> Preserve SSLEngine peer address in SSLContextWrapper
> ----------------------------------------------------
>
> Key: IGNITE-29208
> URL: https://issues.apache.org/jira/browse/IGNITE-29208
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Anton Vinogradov
> Assignee: Anton Vinogradov
> Priority: Major
> Labels: ise
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Preserve the peer host and port when SSLContextWrapper creates an SSLEngine.
> The addressed overload currently calls the delegate without the supplied
> address. Forward host and port to the matching overload while retaining
> configured protocols and cipher suites.
> This affects external callers using the public wrapper constructor, or a
> context from SslContextFactory with custom protocols or cipher suites, to
> create an addressed client engine. Losing the address can prevent the TLS
> provider from sending SNI or reusing a session, and can make hostname
> verification fail when endpoint identification is enabled. The fix preserves
> the address; it does not enable hostname verification. Ignite's current Java
> transports use the overload without an address.
> IGNITE-29209 introduces wrappers for certificate metadata even without custom
> TLS parameters. It needs this fix so exposing metadata preserves the behavior
> of existing addressed client engines. Merge this fix first. Split out of
> IGNITE-28867; it adds no reload behavior.
> Verify through the existing public constructor that the addressed engine
> retains host, port, protocols and cipher suites, and that the no-argument
> overload keeps its existing behavior. The regression test must fail without
> the fix.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
