[ 
https://issues.apache.org/jira/browse/IGNITE-28967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anton Vinogradov resolved IGNITE-28967.
---------------------------------------
    Resolution: Duplicate

Done as part of IGNITE-28528, see https://github.com/apache/ignite/pull/13440 - 
that pull request already touches five of the fifteen files, so the rename went 
in with it.

> Rename GridDeploymentInfoBean to GridDeploymentInfoMessage
> ----------------------------------------------------------
>
>                 Key: IGNITE-28967
>                 URL: https://issues.apache.org/jira/browse/IGNITE-28967
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Anton Vinogradov
>            Priority: Minor
>              Labels: IEP-132, ise
>
> {{GridDeploymentInfoBean}} is a {{Message}} that carries a deployment 
> descriptor inside other messages, but its name says "Bean", which the 
> internal code does not use anywhere else: the remaining {{*Bean}} classes are 
> either Spring ({{IgniteSpringBean}}), public API ({{LifecycleBean}}), or JMX 
> ({{*MBean}}, {{*MXBean}}).
> Classes of the same nature are named without that suffix, for example 
> {{BinaryMetadataVersionInfo}} and {{NodeEncryptionKeys}}, both 
> {{Serializable}} plus {{Message}} parts of other messages.
> The name cannot simply drop the suffix, because the class implements the 
> {{GridDeploymentInfo}} interface, so rename it to 
> {{GridDeploymentInfoMessage}}: it keeps the pair with the interface readable 
> and matches {{ErrorMessage}} and {{QueryEntityMessage}}.
> The change is mechanical: 53 usages in 15 files, no behaviour and no wire 
> format involved.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to