[ 
https://issues.apache.org/jira/browse/IGNITE-28271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18102092#comment-18102092
 ] 

Anton Vinogradov commented on IGNITE-28271:
-------------------------------------------

Merged to master: 5cbb7fc2c1c (PR #13435).

Removing the {{wire-format}} label, and correcting what the PR description says 
about it. I wrote there that this changes the wire format. It does not. 
Comparing the merge commit with its parent:

* the class keeps {{@UseBinaryMarshaller}}, so the same marshaller writes the 
payload;
* {{gridExBytes}}, {{resBytes}} and {{jobAttrsBytes}} keep {{@Order(3)}}, 
{{@Order(4)}} and {{@Order(5)}} and stay {{byte[]}};
* {{CoreMessagesProvider}} is untouched, so the direct type id is the same.

The bytes are identical. What changed is *when* the payload is unmarshalled - 
the message is a {{DeferredUnmarshalMessage}} now, so the consumer does it once 
the deployment class loader is known instead of the generic inbound pass. That 
is receive-side behaviour and is invisible on the wire.

The fixVersion stays 2.19, since that is the release the change goes into.

> Investigate possibity to use ErrorMessage for 
> GridJobExecuteResponse#gridExBytes
> --------------------------------------------------------------------------------
>
>                 Key: IGNITE-28271
>                 URL: https://issues.apache.org/jira/browse/IGNITE-28271
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Ilya Shishkov
>            Assignee: Anton Vinogradov
>            Priority: Minor
>              Labels: ise
>             Fix For: 2.19
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> {{#gridExBytes}} serde via {{ErrorMessage}} was implemented in IGNITE-26817 
> and reverted back to JDK serde in IGNITE-26890. Possibility to use 
> {{ErrorMessage}} should be investigated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to