[
https://issues.apache.org/jira/browse/IGNITE-28953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101957#comment-18101957
]
Ignite TC Bot commented on IGNITE-28953:
----------------------------------------
Docs Required was reviewed against the merged PR and the current Ignite 2
master branch. PR #13434 / commit 54f054c4fd updates Calcite tests and adds an
internal assertion around message factory initialization; it does not change
user-facing SQL behavior, configuration, APIs, commands, operational behavior,
or documentation surface. I am clearing Docs Required and leaving Release Notes
Required unchanged.
> Calcite: PlanExecutionTest and ContinuousExecutionTest fail after
> IGNITE-28937 due to uninitialized message factory
> -------------------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-28953
> URL: https://issues.apache.org/jira/browse/IGNITE-28953
> Project: Ignite
> Issue Type: Bug
> Components: messaging
> Reporter: Anton Vinogradov
> Assignee: Anton Vinogradov
> Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> IGNITE-28937 added an assert to
> AbstractMarshallableMessageFactoryProvider.loadGenerated(): when a generated
> companion constructor takes a Marshaller, the provider must be initialized
> via init() first. In production IgniteKernal#initProvider() always calls
> init(), so the assert never fires there.
> PlanExecutionTest and ContinuousExecutionTest create CalciteMessageFactory
> without calling init() (they only need direct type registration), so 38 tests
> fail in the Calcite SQL 2 suite with:
> {noformat}java.lang.AssertionError: QueryStartRequestMarshaller takes a
> marshaller, but none was provided
> at
> org.apache.ignite.internal.plugin.AbstractMarshallableMessageFactoryProvider.loadGenerated(AbstractMarshallableMessageFactoryProvider.java:118){noformat}
> Fix: initialize the factory with jdk marshallers in these tests, the same way
> core tests do (see CoreMessagesProvider usages with Marshallers.jdk()).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
