[ 
https://issues.apache.org/jira/browse/IGNITE-28945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Steshin updated IGNITE-28945:
--------------------------------------
    Description: 
{code:java}
GridContinuousHandler#p2pMarshal(){code}
are called in two places:
{code:java}
GridContinuousProcessor#startRoutine()
StartRequestData#marshal() {code}
,
{code:java}
GridContinuousHandler#p2pUnmarshal() {code}
are called in 3 places:
{code:java}
GridContinuousProcessor#registerHandlerOnJoin()
GridContinuousProcessor#processStartRequestMutable()
StartRequestData#unmarshal() {code}
 

Such methods calling may issue a duplicated marshalling. The following test can 
be debugged to check duplicated marshalling of:
{code:java}
GridEventConsumeHandler#p2pMarshal()/p2pUnmarshal() : 
testServerJoinWithP2PClassDeployedInCluster()

CacheContinuousQueryHandler#p2pMarshal()/p2pUnmarshal() : 
testContinuousQueryRemoteTransformer()

GridMessageListenHandler#p2pMarshal()/p2pUnmarshal() : 
IgniteClientReconnectContinuousProcessorTest.testMessageListenerReconnectAndStopFromClient()
 {code}
 

Might be irrelevant after [IEP-144 
IgniteClassPath|https://cwiki.apache.org/confluence/spaces/IGNITE/pages/406621573/IEP-144+IgniteClassPath]

  was:
{code:java}
GridContinuousHandler#p2pMarshal(){code}
are called in two places:
{code:java}
GridContinuousProcessor#startRoutine()
StartRequestData#marshal() {code}
,
{code:java}
GridContinuousHandler#p2pMarshal() {code}
are called in 3 places:
{code:java}
GridContinuousProcessor#registerHandlerOnJoin()
GridContinuousProcessor#processStartRequestMutable()
StartRequestData#unmarshal() {code}
 

Such methods calling may issue a duplicated marshalling. The following test can 
be debugged to check duplicated marshalling of:
{code:java}
GridEventConsumeHandler#p2pMarshal()/p2pUnmarshal() : 
testServerJoinWithP2PClassDeployedInCluster()

CacheContinuousQueryHandler#p2pMarshal()/p2pUnmarshal() : 
testContinuousQueryRemoteTransformer()

GridMessageListenHandler#p2pMarshal()/p2pUnmarshal() : 
IgniteClientReconnectContinuousProcessorTest.testMessageListenerReconnectAndStopFromClient()
 {code}
 

Might be irrelevant after [IEP-144 
IgniteClassPath|https://cwiki.apache.org/confluence/spaces/IGNITE/pages/406621573/IEP-144+IgniteClassPath]


> Duplicated marshalling of GridContinuousHandler
> -----------------------------------------------
>
>                 Key: IGNITE-28945
>                 URL: https://issues.apache.org/jira/browse/IGNITE-28945
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Vladimir Steshin
>            Priority: Minor
>
> {code:java}
> GridContinuousHandler#p2pMarshal(){code}
> are called in two places:
> {code:java}
> GridContinuousProcessor#startRoutine()
> StartRequestData#marshal() {code}
> ,
> {code:java}
> GridContinuousHandler#p2pUnmarshal() {code}
> are called in 3 places:
> {code:java}
> GridContinuousProcessor#registerHandlerOnJoin()
> GridContinuousProcessor#processStartRequestMutable()
> StartRequestData#unmarshal() {code}
>  
> Such methods calling may issue a duplicated marshalling. The following test 
> can be debugged to check duplicated marshalling of:
> {code:java}
> GridEventConsumeHandler#p2pMarshal()/p2pUnmarshal() : 
> testServerJoinWithP2PClassDeployedInCluster()
> CacheContinuousQueryHandler#p2pMarshal()/p2pUnmarshal() : 
> testContinuousQueryRemoteTransformer()
> GridMessageListenHandler#p2pMarshal()/p2pUnmarshal() : 
> IgniteClientReconnectContinuousProcessorTest.testMessageListenerReconnectAndStopFromClient()
>  {code}
>  
> Might be irrelevant after [IEP-144 
> IgniteClassPath|https://cwiki.apache.org/confluence/spaces/IGNITE/pages/406621573/IEP-144+IgniteClassPath]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to