[
https://issues.apache.org/jira/browse/IGNITE-28943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Werner updated IGNITE-28943:
-----------------------------------
Description:
1. In SecurityBasicPermissionSetSerializationTest#testWriteAndReadBack, the
line `src.setCachePermissions(Map.of("cache", Set.of(CACHE_CREATE,
CACHE_PUT)));` is duplicated.
In method deepEquals, there is a typo where lhs is missing. The condition
checks rhs twice:
{code:java}
(F.isEmpty(rhs.systemPermissions()) && F.isEmpty(rhs.systemPermissions())){code}
2. MessageProcessorTest#testCustomMapperCannotBeUsedOnNonEnumCollection test
should verify the compilation of CustomEnumMapperOnNonEnumCollectionMessage,
not CustomEnumMapperOnArrayFieldMessage.
was:
In SecurityBasicPermissionSetSerializationTest#testWriteAndReadBack, the line
`src.setCachePermissions(Map.of("cache", Set.of(CACHE_CREATE, CACHE_PUT)));` is
duplicated.
In method deepEquals, there is a typo where lhs is missing. The condition
checks rhs twice:
{code:java}
(F.isEmpty(rhs.systemPermissions()) && F.isEmpty(rhs.systemPermissions())){code}
> Cleanup in SecurityBasicPermissionSetSerializationTest and
> MessageProcessorTest
> -------------------------------------------------------------------------------
>
> Key: IGNITE-28943
> URL: https://issues.apache.org/jira/browse/IGNITE-28943
> Project: Ignite
> Issue Type: Test
> Reporter: Dmitry Werner
> Assignee: Dmitry Werner
> Priority: Trivial
>
> 1. In SecurityBasicPermissionSetSerializationTest#testWriteAndReadBack, the
> line `src.setCachePermissions(Map.of("cache", Set.of(CACHE_CREATE,
> CACHE_PUT)));` is duplicated.
> In method deepEquals, there is a typo where lhs is missing. The condition
> checks rhs twice:
> {code:java}
> (F.isEmpty(rhs.systemPermissions()) &&
> F.isEmpty(rhs.systemPermissions())){code}
> 2. MessageProcessorTest#testCustomMapperCannotBeUsedOnNonEnumCollection test
> should verify the compilation of CustomEnumMapperOnNonEnumCollectionMessage,
> not CustomEnumMapperOnArrayFieldMessage.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
