[ 
https://issues.apache.org/jira/browse/IGNITE-27606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18100785#comment-18100785
 ] 

Anton Vinogradov commented on IGNITE-27606:
-------------------------------------------

This is a wire format change, so it has to be merged before 2.19 is released. 
After that it would break rolling upgrade.

The counters are on the wire as a single hand-packed blob: 
PartitionUpdateCountersMessage has {{@Order(1) byte[] data}}, filled through 
GridUnsafe with a fixed 20-byte item layout (4 bytes partition + 8 bytes 
initial counter + 8 bytes updates count). Any replacement of the raw array with 
typed fields changes the message schema, so the note in the description about 
keeping "network serialization behavior" only holds if the {{byte[]}} field 
itself stays. If the chosen solution does keep it, please say so in the ticket 
and the fixVersion can be dropped.

> Investigate PartitionUpdateCountersMessage to remove GridUnsafe and raw array 
> counter transforms
> ------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-27606
>                 URL: https://issues.apache.org/jira/browse/IGNITE-27606
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Aleksandr Chesnokov
>            Priority: Major
>              Labels: IEP-132
>             Fix For: 2.19
>
>
> The current implementation of PartitionUpdateCountersMessage performs counter 
> transformations using raw arrays and GridUnsafe. Propose and implement an 
> alternative approach that avoids GridUnsafe and reduces low-level array 
> manipulation, without regressions in performance or network serialization 
> behavior



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to