[ 
https://issues.apache.org/jira/browse/IGNITE-28767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18092720#comment-18092720
 ] 

Ignite TC Bot commented on IGNITE-28767:
----------------------------------------

{panel:title=Branch: [pull/13236/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/13236/head] Base: [master] : New Tests 
(2)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Continuous Query 4{color} [[tests 
2|https://ci2.ignite.apache.org/viewLog.html?buildId=9159679]]
* {color:#013220}IgniteCacheQuerySelfTestSuite6: 
QueryEntityMessageSerializationTest.testQueryEntityEx - PASSED{color}
* {color:#013220}IgniteCacheQuerySelfTestSuite6: 
QueryEntityMessageSerializationTest.testQueryEntity - PASSED{color}

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=9159785&buildTypeId=IgniteTests24Java8_RunAll]
{color:#ffffff}tcbot-analysis-comment chainBuildId=9159785 
rerunBuildIds=9163555,9163557,9163559,9163561,9163563{color}

> Use Message DTO to transfer QueryEntity
> ---------------------------------------
>
>                 Key: IGNITE-28767
>                 URL: https://issues.apache.org/jira/browse/IGNITE-28767
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Ilya Shishkov
>            Assignee: Ilya Shishkov
>            Priority: Minor
>              Labels: IEP-132, ise
>             Fix For: 2.19
>
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> As much as possible DTO's transferred inside the {{DiscoveryDataBag}} 
> ({{DiscoveryDataPacket}}) should be transfromed to a {{Message}}.
> The following DTO's implement {{Serializable}}:
> # {{QueryEntity}}
> # {{QueryEntityEx}}
> They are transferred in the {{DiscoveryDataBag}} ({{DiscoveryDataPacket}}): 
> {{QueryProposalsDataBagItem}} -> {{SchemaProposeDiscoveryMessage}} -> 
> {{SchemaAbstractOperation}} -> {{SchemaAddQueryEntityOperation}}.  
> Some important tips:
> # Implementation of {{Serializable}} should be removed if possible. (If not 
> stored somewhere in MetaStorage, or in PDS).
> # If it is difficult to transform a DTO to a {{Message}} or DTO belongs to 
> the public API, message-clone for DTO can be added, eg. {{QueryIndexMessage}}.
> # Keep in mind {{#writeObject}} / {{#readObject}} and {{#readExternal}} / 
> {{#writeExternal}} methods, if any.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to