[
https://issues.apache.org/jira/browse/IGNITE-26397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018735#comment-18018735
]
Roman Puchkovskiy commented on IGNITE-26397:
--------------------------------------------
The patch looks good to me
> OutNetworkObject constructor with shouldBeSavedForRecovery is redundant
> -----------------------------------------------------------------------
>
> Key: IGNITE-26397
> URL: https://issues.apache.org/jira/browse/IGNITE-26397
> Project: Ignite
> Issue Type: Improvement
> Reporter: Vladislav Pyatkov
> Assignee: Vladislav Pyatkov
> Priority: Major
> Labels: ignite-3
> Time Spent: 10m
> Remaining Estimate: 0h
>
> h3. Motivation
> The initial value of property _shouldBeSavedForRecovery_ always the same as
> with _NetworkMessage#needAck_. It also makes a disadvantage when we add a
> message without acknowledgment because we have to change a constructor as
> well (use one with 3 params).
> h3. Definition of done
> Leave only a constructor with 2 params.
> Property _shouldBeSavedForRecovery_ should be initialized by needAck.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
