[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424111#comment-15424111
]
Anton Vinogradov commented on IGNITE-3303:
------------------------------------------
{noformat}
The LinkedBlockingQueue is static as we would like to have single queue for the
source. The IgnitePredicate filter can be static as it does not have a state
associated with it and it just filter on CacheEvents.
{noformat}
I think we should mark as "static" only fields shared between instances.
I'm not so familiar with flink as you, but, seems that by design, currently,
possible to create more than one IgniteSource instance. In case we want to
allow to create only one instance we have to use singleton pattern.
In case more that one instance allowed please add concurrent tests (more than
one instance at one test) and check each output and there is no issues.
Anyway, static fields should be static only in case they should be :) Static
fields is the way to gain memory leak.
> Apache Flink Integration - Flink source to run a continuous query against one
> or multiple caches
> ------------------------------------------------------------------------------------------------
>
> Key: IGNITE-3303
> URL: https://issues.apache.org/jira/browse/IGNITE-3303
> Project: Ignite
> Issue Type: New Feature
> Components: streaming
> Reporter: Saikat Maitra
> Assignee: Anton Vinogradov
>
> Apache Flink integration
> +++ *Ignite as a bidirectional Connector* +++
> As a Flink source => run a continuous query against one or multiple
> caches [4].
> Related discussion :
> http://apache-ignite-developers.2346864.n4.nabble.com/Apache-Flink-lt-gt-Apache-Ignite-integration-td8163.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
