[ https://issues.apache.org/jira/browse/IGNITE-25110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Stanilovsky updated IGNITE-25110: ---------------------------------------- Description: This issue is the same as [1] but targeted for ai-3. Seems also numerous tests are failed from SqlLogicTests during decorrelation enabled. Set of failed tests: {noformat} test_not_distinct_from.test test_correlated_any_all.test test_correlated_exists.test test_correlated_aggregate_subquery.test test_correlated_subquery.test test_correlated_subquery_cte.test test_count_star_subquery.test {noformat} *test_correlated_exists.test* and *test_not_distinct_from.test* can be fixed in org.apache.calcite.sql2rel.RelDecorrelator#decorrelateRel(org.apache.calcite.rel.core.Correlate, boolean) Original: {noformat} conditions.add( relBuilder.equals(RexInputRef.of(newLeftPos, newLeftOutput), new RexInputRef(newLeftFieldCount + newRightPos, newRightOutput.get(newRightPos).getType()))); {noformat} seems need to be changed to: {noformat} conditions.add( relBuilder.isNotDistinctFrom(RexInputRef.of(newLeftPos, newLeftOutput), new RexInputRef(newLeftFieldCount + newRightPos, newRightOutput.get(newRightPos).getType()))); {noformat} [1] https://issues.apache.org/jira/browse/IGNITE-16493 was: This issue is the same as [1] but targeted for ai-3. Seems also numerous tests are failed from SqlLogicTests during decorrelation enabled. Set of failed tests: {noformat} test_not_distinct_from.test test_correlated_any_all.test test_correlated_exists.test test_correlated_aggregate_subquery.test test_correlated_subquery.test test_correlated_subquery_cte.test test_count_star_subquery.test {noformat} *test_correlated_exists.test* can be fixed in org.apache.calcite.sql2rel.RelDecorrelator#decorrelateRel(org.apache.calcite.rel.core.Correlate, boolean) Original: {noformat} conditions.add( relBuilder.equals(RexInputRef.of(newLeftPos, newLeftOutput), new RexInputRef(newLeftFieldCount + newRightPos, newRightOutput.get(newRightPos).getType()))); {noformat} seems need to be changed to: {noformat} conditions.add( relBuilder.isNotDistinctFrom(RexInputRef.of(newLeftPos, newLeftOutput), new RexInputRef(newLeftFieldCount + newRightPos, newRightOutput.get(newRightPos).getType()))); {noformat} [1] https://issues.apache.org/jira/browse/IGNITE-16493 > Sql. Investigate possibility to use query decorrelation > ------------------------------------------------------- > > Key: IGNITE-25110 > URL: https://issues.apache.org/jira/browse/IGNITE-25110 > Project: Ignite > Issue Type: Task > Components: sql > Affects Versions: 3.0.0-beta1 > Reporter: Evgeny Stanilovsky > Assignee: Evgeny Stanilovsky > Priority: Major > Labels: ignite-3 > > This issue is the same as [1] but targeted for ai-3. > Seems also numerous tests are failed from SqlLogicTests during decorrelation > enabled. > Set of failed tests: > {noformat} > test_not_distinct_from.test > test_correlated_any_all.test > test_correlated_exists.test > test_correlated_aggregate_subquery.test > test_correlated_subquery.test > test_correlated_subquery_cte.test > test_count_star_subquery.test > {noformat} > *test_correlated_exists.test* and *test_not_distinct_from.test* can be fixed > in > org.apache.calcite.sql2rel.RelDecorrelator#decorrelateRel(org.apache.calcite.rel.core.Correlate, > boolean) > Original: > {noformat} > conditions.add( > relBuilder.equals(RexInputRef.of(newLeftPos, newLeftOutput), > new RexInputRef(newLeftFieldCount + newRightPos, > newRightOutput.get(newRightPos).getType()))); > {noformat} > seems need to be changed to: > {noformat} > conditions.add( > relBuilder.isNotDistinctFrom(RexInputRef.of(newLeftPos, > newLeftOutput), > new RexInputRef(newLeftFieldCount + newRightPos, > newRightOutput.get(newRightPos).getType()))); > {noformat} > [1] https://issues.apache.org/jira/browse/IGNITE-16493 -- This message was sent by Atlassian Jira (v8.20.10#820010)