[ https://issues.apache.org/jira/browse/IGNITE-25068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942237#comment-17942237 ]
Roman Puchkovskiy commented on IGNITE-25068: -------------------------------------------- The patch looks good to me > Decouple PartitionSnapshotStorage from JRaft and enclosing factory > ------------------------------------------------------------------ > > Key: IGNITE-25068 > URL: https://issues.apache.org/jira/browse/IGNITE-25068 > Project: Ignite > Issue Type: Improvement > Reporter: Aleksandr Polovtsev > Assignee: Aleksandr Polovtsev > Priority: Major > Labels: ignite-3 > Time Spent: 0.5h > Remaining Estimate: 0h > > There exists a strange design where PartitionSnapshotStorageFactory contains > a set of table partition storages (for the colocation case) which is > propagated to the PartitionSnapshotStorage. This leads to concurrency issues > and unclear code, because the set is updated concurrently outside of the > PartitionSnapshotStorage. Instead, this set must be moved inside the > PartitionSnapshotStorage. -- This message was sent by Atlassian Jira (v8.20.10#820010)