[ https://issues.apache.org/jira/browse/IGNITE-25012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941538#comment-17941538 ]
Ignite TC Bot commented on IGNITE-25012: ---------------------------------------- {panel:title=Branch: [pull/11982/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/11982/head] Base: [master] : New Tests (29)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1} {color:#00008b}PDS (Compatibility){color} [[tests 24|https://ci2.ignite.apache.org/viewLog.html?buildId=8383746]] * {color:#013220}IgniteCompatibilityBasicTestSuite: SnapshotCompatibilityTest.testSnapshotRestore[incrementalSnp=true, consistentID=c3432512-486d-4e78-b6a0-80b317f92b01, oldNodesCnt=1, cacheDump=false, customSnpPath=false, testCacheGrp=true] - PASSED{color} * {color:#013220}IgniteCompatibilityBasicTestSuite: SnapshotCompatibilityTest.testSnapshotRestore[incrementalSnp=true, consistentID=c3432512-486d-4e78-b6a0-80b317f92b01, oldNodesCnt=1, cacheDump=false, customSnpPath=true, testCacheGrp=false] - PASSED{color} * {color:#013220}IgniteCompatibilityBasicTestSuite: SnapshotCompatibilityTest.testSnapshotRestore[incrementalSnp=true, consistentID=c3432512-486d-4e78-b6a0-80b317f92b01, oldNodesCnt=1, cacheDump=false, customSnpPath=true, testCacheGrp=true] - PASSED{color} * {color:#013220}IgniteCompatibilityBasicTestSuite: SnapshotCompatibilityTest.testSnapshotRestore[incrementalSnp=true, consistentID=c3432512-486d-4e78-b6a0-80b317f92b01, oldNodesCnt=3, cacheDump=false, customSnpPath=false, testCacheGrp=true] - PASSED{color} * {color:#013220}IgniteCompatibilityBasicTestSuite: SnapshotCompatibilityTest.testSnapshotRestore[incrementalSnp=true, consistentID=c3432512-486d-4e78-b6a0-80b317f92b01, oldNodesCnt=3, cacheDump=false, customSnpPath=true, testCacheGrp=false] - PASSED{color} * {color:#013220}IgniteCompatibilityBasicTestSuite: SnapshotCompatibilityTest.testSnapshotRestore[incrementalSnp=true, consistentID=c3432512-486d-4e78-b6a0-80b317f92b01, oldNodesCnt=3, cacheDump=false, customSnpPath=true, testCacheGrp=true] - PASSED{color} * {color:#013220}IgniteCompatibilityBasicTestSuite: SnapshotCompatibilityTest.testSnapshotRestore[incrementalSnp=true, consistentID=c3432512-486d-4e78-b6a0-80b317f92b01, oldNodesCnt=1, cacheDump=false, customSnpPath=false, testCacheGrp=false] - PASSED{color} * {color:#013220}IgniteCompatibilityBasicTestSuite: SnapshotCompatibilityTest.testSnapshotRestore[incrementalSnp=false, consistentID=c3432512-486d-4e78-b6a0-80b317f92b01, oldNodesCnt=1, cacheDump=true, customSnpPath=false, testCacheGrp=true] - PASSED{color} * {color:#013220}IgniteCompatibilityBasicTestSuite: SnapshotCompatibilityTest.testSnapshotRestore[incrementalSnp=false, consistentID=c3432512-486d-4e78-b6a0-80b317f92b01, oldNodesCnt=1, cacheDump=true, customSnpPath=true, testCacheGrp=false] - PASSED{color} * {color:#013220}IgniteCompatibilityBasicTestSuite: SnapshotCompatibilityTest.testSnapshotRestore[incrementalSnp=false, consistentID=c3432512-486d-4e78-b6a0-80b317f92b01, oldNodesCnt=1, cacheDump=true, customSnpPath=true, testCacheGrp=true] - PASSED{color} * {color:#013220}IgniteCompatibilityBasicTestSuite: SnapshotCompatibilityTest.testSnapshotRestore[incrementalSnp=true, consistentID=c3432512-486d-4e78-b6a0-80b317f92b01, oldNodesCnt=3, cacheDump=false, customSnpPath=false, testCacheGrp=false] - PASSED{color} ... and 13 new tests {color:#00008b}Cache 13{color} [[tests 5|https://ci2.ignite.apache.org/viewLog.html?buildId=8383689]] * {color:#013220}IgniteCacheTestSuite13: SystemViewCacheExpiryPolicyTest.testCacheViewExpiryPolicy[factory=org.apache.ignite.internal.processors.platform.cache.expiry.PlatformExpiryPolicyFactory@5927f904, actual=PlatformExpiryPolicyFactory [create=2, update=4, access=8, expiryPlc=PlatformExpiryPolicy [create=2 MILLISECONDS, update=4 MILLISECONDS, access=8 MILLISECONDS]]] - PASSED{color} * {color:#013220}IgniteCacheTestSuite13: SystemViewCacheExpiryPolicyTest.testCacheViewExpiryPolicy[factory=javax.cache.configuration.FactoryBuilder$SingletonFactory@42ed89da, actual=SingletonFactory [expiryPlc=EternalExpiryPolicy [create=ETERNAL]]] - PASSED{color} * {color:#013220}IgniteCacheTestSuite13: SystemViewCacheExpiryPolicyTest.testCacheViewExpiryPolicy[factory=org.apache.ignite.internal.processors.platform.cache.expiry.PlatformExpiryPolicyFactory@644d1b61, actual=PlatformExpiryPolicyFactory [create=0, update=1, access=-1, expiryPlc=PlatformExpiryPolicy [create=ZERO, update=1 MILLISECONDS, access=ETERNAL]]] - PASSED{color} * {color:#013220}IgniteCacheTestSuite13: SystemViewCacheExpiryPolicyTest.testCacheViewExpiryPolicy[factory=org.apache.ignite.internal.processors.platform.cache.expiry.PlatformExpiryPolicyFactory@413d2cd1, actual=PlatformExpiryPolicyFactory [create=-1, update=0, access=-1, expiryPlc=PlatformExpiryPolicy [create=ETERNAL, update=ZERO, access=ETERNAL]]] - PASSED{color} * {color:#013220}IgniteCacheTestSuite13: SystemViewCacheExpiryPolicyTest.testCacheViewExpiryPolicy[factory=org.apache.ignite.internal.processors.platform.cache.expiry.PlatformExpiryPolicyFactory@2bb62414, actual=PlatformExpiryPolicyFactory [create=1, update=-2, access=-1, expiryPlc=PlatformExpiryPolicy [create=1 MILLISECONDS, access=ETERNAL]]] - PASSED{color} {panel} [TeamCity *--> Run :: All* Results|https://ci2.ignite.apache.org/viewLog.html?buildId=8383795&buildTypeId=IgniteTests24Java8_RunAll] > GridToStringBuilder: extract GridUnsafe operations > --------------------------------------------------- > > Key: IGNITE-25012 > URL: https://issues.apache.org/jira/browse/IGNITE-25012 > Project: Ignite > Issue Type: Sub-task > Reporter: Nikolay Izhikov > Assignee: Nikolay Izhikov > Priority: Major > Labels: ise > Time Spent: 20m > Remaining Estimate: 0h > > GridToStringBuilder contains some GridUnsafe invocation. > To be able to extract it into ignite-commons we must refactor it. > 1. Create methods `getBooleanField`, `getObjectField` and similar inside > GridToStringFieldDescriptor. > > 2. GridToStringFieldDescriptor instance must be created by some mutable > factory > 3. By default, new methods must be implement with the regular reflection API. > 4. ignite-core must keep `UnsafeGridToStringFieldDescriptor` which will use > existing Unsafe logic. > This way we can safely move GridToStringBuilder without dependencies on > GridUnsafe code -- This message was sent by Atlassian Jira (v8.20.10#820010)