[
https://issues.apache.org/jira/browse/IGNITE-24835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938114#comment-17938114
]
Pavel Pereslegin commented on IGNITE-24835:
-------------------------------------------
[~zstan],
please take a look at the proposed changes.
> Sql. Forbid TIMESTAMP WITH TIME ZONE on parser level
> ----------------------------------------------------
>
> Key: IGNITE-24835
> URL: https://issues.apache.org/jira/browse/IGNITE-24835
> Project: Ignite
> Issue Type: Improvement
> Components: sql
> Affects Versions: 3.0
> Reporter: Pavel Pereslegin
> Assignee: Pavel Pereslegin
> Priority: Major
> Labels: ignite-3
> Fix For: 3.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{TIME WITH [LOCAL] TIME ZONE}}} was forbidden on parser level, but
> {{TIMESTAMP WITH TIME ZONE}} successfully parses and produces unexpected
> exception (IGN-CMN-65535).
> {noformat}
> Caused by: java.lang.IllegalArgumentException: Unexpected type: TIMESTAMP_TZ
> at
> org.apache.ignite.internal.sql.engine.util.TypeUtils.columnType(TypeUtils.java:372)
> at
> org.apache.ignite.internal.sql.engine.prepare.IgniteSqlValidator.validatePrecisionScale(IgniteSqlValidator.java:981)
> at
> org.apache.ignite.internal.sql.engine.prepare.IgniteSqlValidator.validateDataType(IgniteSqlValidator.java:964)
> at
> org.apache.ignite.internal.sql.engine.prepare.IgnitePlanner.convert(IgnitePlanner.java:232)
> {noformat}
> Definition of done:
> * Forbid TIMESTAMP WITH TIME ZONE on parser level
> * Extend parser test coverage (see timeWithLocalTimeZoneIsNotSupported) with
> all known forbidden types ({{TIME WITH LOCAL TIME ZONE}}, {{TIME WITH TIME
> ZONE}}, {{TIMESTAMP WITH TIME ZONE}} for {{CREATE TABLE / ALTER TABLE ADD
> COLUMN...}} statements.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
