[
https://issues.apache.org/jira/browse/IGNITE-24920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940581#comment-17940581
]
Ivan Bessonov commented on IGNITE-24920:
----------------------------------------
Just a comment:
* Shouldn't we only allow a space after `IGNITE-*****`? I would not want a
tabulation to be allowed there, so the \s usage is questionable
* Why are we bracketing tokens? I guess that's a stylistic choice
* Branches should be lower-cased
> Make a commit hook to verify commit message for Ignite 3 commits
> ----------------------------------------------------------------
>
> Key: IGNITE-24920
> URL: https://issues.apache.org/jira/browse/IGNITE-24920
> Project: Ignite
> Issue Type: Improvement
> Components: build
> Reporter: Ivan Zlenko
> Priority: Major
> Labels: ignite-3
>
> We need to add a commit hook so we can verify that commit message following
> correct format set in our company.
> The following rules should apply:
> # Commit message should start with a ticket number matching pattern
> ^IGNITE-[\d]+
> # After commit number, separated only by whitespace, the short commit message
> should follow. So the complete patter for the first line of the commit
> message should be: ^IGNITE-[\d]+[\s].*
> # Ideally we should verify that commit number in commit message should be the
> same as the branch name.
> These rules should apply for main branch and for branches matching
> ^IGNITE-[\d]+ pattern if it is possible. Or for the main branch only if it is
> not. In that case incorrect commit message/PR title should prevent the merge
> into the main branch.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
