[ 
https://issues.apache.org/jira/browse/IGNITE-24769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roman Puchkovskiy updated IGNITE-24769:
---------------------------------------
    Description: 
LogicalNode currently extends ClusterNodeImpl. This causes difficulties (for 
example, we are sometimes tempted to use Set.contains() to check that set of 
nodes of one kind contains a node of another kind; but equals() might not be 
compatible, this creates a potential for subtle bugs.

It is suggested to replace inheritance with aggregation (that is, LogicalNode 
should not extend ClusterNodeImpl, but instead contain an instance of it).

> Separate LogicalNode from ClusterNodeImpl
> -----------------------------------------
>
>                 Key: IGNITE-24769
>                 URL: https://issues.apache.org/jira/browse/IGNITE-24769
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Vadim Pakhnushev
>            Priority: Major
>              Labels: ignite-3
>
> LogicalNode currently extends ClusterNodeImpl. This causes difficulties (for 
> example, we are sometimes tempted to use Set.contains() to check that set of 
> nodes of one kind contains a node of another kind; but equals() might not be 
> compatible, this creates a potential for subtle bugs.
> It is suggested to replace inheritance with aggregation (that is, LogicalNode 
> should not extend ClusterNodeImpl, but instead contain an instance of it).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to