[
https://issues.apache.org/jira/browse/IGNITE-24570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933931#comment-17933931
]
Mikhail Efremov commented on IGNITE-24570:
------------------------------------------
The first part of the ticket was to look up for an approach to search the
corresponding properties. The result is 4 entry point of {{*#properties()}}
methods calls for usage checks:
* {{SystemLocalConfiguration#properties}}
* {{SystemDistributedConfiguration#properties}}
* {{SystemLocalView#properties}}
* {{SystemDistributedView#properties}}
There 5 properties were found:
* {{LOCK_MAP_SIZE_PROPERTY_NAME = "lockMapSize"}}
* {{INTERVAL_SYSTEM_PROPERTY_NAME = "metastorageCompactionInterval"}}
* {{DATA_AVAILABILITY_TIME_SYSTEM_PROPERTY_NAME =
"metastorageCompactionDataAvailabilityTime"}}
* {{PARTITION_DISTRIBUTION_RESET_TIMEOUT = "partitionDistributionResetTimeout"}}
* {{REBALANCE_RETRY_DELAY_MS = "rebalanceRetryDelay"}}
Also 2nd and 3rd properties are duplicated for tests and there is a follow up
test to fix this: https://issues.apache.org/jira/browse/IGNITE-24749
> Search for inappropriate ignite system local and distributed configuration
> properties
> -------------------------------------------------------------------------------------
>
> Key: IGNITE-24570
> URL: https://issues.apache.org/jira/browse/IGNITE-24570
> Project: Ignite
> Issue Type: Task
> Reporter: Mikhail Efremov
> Assignee: Mikhail Efremov
> Priority: Major
> Labels: ignite-3
>
> *Description*
> After a discussion there is an issue with system configuration properties in
> AI3 code base within {{SystemLocalConfigurationSchema#properties}} and
> {{SystemDistributedConfigurationSchema#properties}} maps. Some properties of
> the maps may be a public configuration entries and then be documented for
> users.
> *Motivation*
> We should use strict policy for configuration and hide in system
> configuration properties only private internal entries and don't use it as
> an unmaintained property bag.
> *Definition of Done*
> 1. All system configuration properties from
> {{SystemLocalConfigurationSchema}} and
> {{SystemDistributedConfigurationSchema}} are inspected and developers who
> added them are communicated.
> 2. All system properties that are intended for public node configuration
> should be mentioned in the new ticket about changing mistaken properties to
> configuration entries.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
