[ 
https://issues.apache.org/jira/browse/IGNITE-24029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914925#comment-17914925
 ] 

Andrey Mashenkov commented on IGNITE-24029:
-------------------------------------------

[~ptupitsyn], [~isapego], 
I've prepared a PR for supporting Sql-schema for tables and found a platform 
clients do not follow SQL convention for identifiers (table names) and some 
tests were failed.
I've fixed these tests and add TODOs, which should be resolved in follow-up 
tickets [1], [2].

Would you please do review for the changes in platform code?
For your convenience, the PR contains 2 separate commits that affect only .NET 
and C++ code.

https://issues.apache.org/jira/browse/IGNITE-24258 - .NET
https://issues.apache.org/jira/browse/IGNITE-24261 - C++

> Sql schema. Extend Table API with supporting qualified names.
> -------------------------------------------------------------
>
>                 Key: IGNITE-24029
>                 URL: https://issues.apache.org/jira/browse/IGNITE-24029
>             Project: Ignite
>          Issue Type: Improvement
>          Components: sql
>            Reporter: Pavel Pereslegin
>            Assignee: Andrey Mashenkov
>            Priority: Major
>              Labels: ignite-3
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> It is necessary to introduce new methods in IgniteTables that use 
> {{QualifiedName}} instead of simple String.
> And change the old ones to use the new ones using the helper method 
> {{{}QualifiedName.parseof(String){}}}.
> {code:java}
> interface IgniteTables {
>     /** Gets a list of all tables */
>     List<Table> tables();
>     /** Gets a list of tables that belong to requested schema. */
>     List<Table> tables(String schemaName); // optional
>     /** Gets a table with specified name. */
>     @Nullable Table table(QualifiedName tableName);
>     @Nullable Table table(String tableName) {
>         return table(QualifiedName.parseof(tableName));
>     }
>     /* ... + async methods ... */
> }
> public interface Table {   
>     /** Returns table's qualified name. */    
>     QualifiedName tableName();
> } 
> {code}
> Add integration tests, which checks cache names are correctly resolved.
> Add table::name that returns a QualifiedName.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to