Mikhail Efremov created IGNITE-22373:
----------------------------------------
Summary: Delete startReplica overloadings from ReplicaManager
Key: IGNITE-22373
URL: https://issues.apache.org/jira/browse/IGNITE-22373
Project: Ignite
Issue Type: Improvement
Reporter: Mikhail Efremov
Assignee: Mikhail Efremov
*Description*
After IGNITE-21805 there are still 2 redundant {{Replica#startReplica}}
overloads:
{code:java}
public CompletableFuture<Boolean> startReplica(
ReplicationGroupId replicaGrpId,
PeersAndLearners newConfiguration,
Consumer<RaftGroupService> updateTableRaftService,
Function<RaftGroupService, ReplicaListener> createListener,
PendingComparableValuesTracker<Long, Void> storageIndexTracker,
CompletableFuture<TopologyAwareRaftGroupService> newRaftClientFut
) { ... }
{code}
{code:java}
public CompletableFuture<Replica> startReplica(
ReplicationGroupId replicaGrpId,
PendingComparableValuesTracker<Long, Void> storageIndexTracker,
CompletableFuture<ReplicaListener> newReplicaListenerFut
) { ... }
{code}
They are marked now as {{@VisibleForTesting}} and {{@Deprecated}} both and
their only purpose is to be used in tests.
The main goal of this ticket is to delete them or make them private.
*Motivation*
There should the only one public {{Replica#startReplica}} method for
replication group creation.
*Definition of Done*
1. Both provided above overloads of {{Replica#startReplica}} should be deleted
or be private.
2. All tests that called the overloaded methods should be fixed in favor of the
single {{Replica#startReplica}} method which is called now in {{TableManager}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
