[
https://issues.apache.org/jira/browse/IGNITE-19819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799313#comment-17799313
]
Ivan Bessonov commented on IGNITE-19819:
----------------------------------------
Please also consider a more space-efficient way to pack values into byte[], I
have a quick POC here: [https://github.com/apache/ignite-3/pull/2976]
The payload in the POC is about 10 times less than in main. Integrating similar
ideas into the proposed improvement could make it better
> Lease batches compaction
> ------------------------
>
> Key: IGNITE-19819
> URL: https://issues.apache.org/jira/browse/IGNITE-19819
> Project: Ignite
> Issue Type: Improvement
> Reporter: Denis Chudov
> Priority: Major
> Labels: ignite-3
>
> *Motivation*
> After IGNITE-19578 leases should be stored as a single batch in meta storage.
> However, the size of such a batch is significant and can be reduced.
> Each lease contains group name, leaseholder name, left and right timestamp
> and couple of boolean flags.
> Many leases share the same leaseholder. Also, many leases share the same
> right border, as batch of leases are renewed on every iteration of lease
> updater and get the same right border.
> So, the compacted data structure for all leases could be a map
> {code:java}
> right border -> set of leaseholders -> set of leases which contain only group
> name, left border and flags.{code}
> It is important that this data structure is applicable to meta storage
> representation, in-memory representation of leases should remain the same.
> *Definition of done*
> Amount of space required for storing leases is significantly reduced.
> *Implementation notes*
> The key should be prefix + right border. On each iteration the corresponding
> right border should be removed and new one put, so on each iteration there
> will be done just one meta storage invoke.
> To avoid ABA problem during leases' updates via invokes, entries should be
> versioned, this can be done by assigning unique version to each right border
> key. There are cases when all leaseholders can be removed from some entry and
> then another leaseholders added again (e.g. accepting leases and removing
> them from right border that matches long-term unaccepted leases, and later
> adding the regular leases to the same right border). In this cases the entry
> should not be removed from meta storage, in spite it doesn't have leases, to
> preserve the version of the entry.
> To avoid merging of batches, lease prolongation should be changed: new right
> border should be calculated as current_right_border + lease_interval (now:
> current_time + lease_interval ).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
