[ https://issues.apache.org/jira/browse/IGNITE-20537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771353#comment-17771353 ]
Vladislav Pyatkov commented on IGNITE-20537: -------------------------------------------- The patch looked good to me. > Add ability to create implicit transactions > ------------------------------------------- > > Key: IGNITE-20537 > URL: https://issues.apache.org/jira/browse/IGNITE-20537 > Project: Ignite > Issue Type: Improvement > Reporter: Roman Puchkovskiy > Assignee: Roman Puchkovskiy > Priority: Major > Labels: ignite-3 > Fix For: 3.0.0-beta2 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, implicit transactions are created in {{{}InternalTableImpl{}}}. > where the code knows whether it created the transaction itself or not. To > correctly support schema synchronization, we need to create implicit > transactions higher, in {{RecordBinaryViewImpl}} and other table views (if no > transaction was provided), because transaction is used to obtain a timestamp > used for schema sync. > Such transactions will be created before the code in {{InternalTableImpl}} > that will use them, so {{implicit()}} method is to be added to > {{{}InternalTransaction{}}}. -- This message was sent by Atlassian Jira (v8.20.10#820010)