[ 
https://issues.apache.org/jira/browse/IGNITE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yury Gerzhedovich updated IGNITE-20432:
---------------------------------------
    Description: 
For now below code part is commented with ignite-19938 TODO, which is not 
relevant one.
The goal of this issue is to align the correctness of method call usage.
{noformat}
    private static int defaultLength(ColumnType columnType, int precision) {
        switch (columnType) {
            case BITMASK:
            case STRING:
            case BYTE_ARRAY:
                return DEFAULT_VARLEN_LENGTH;
            default:
                return Math.max(DEFAULT_LENGTH, precision);
        }
    }
{noformat}

Most probably we need amend just date/time 

  was:
For now below code part is commented with ignite-19938 TODO, which is not 
relevant one.
The goal of this issue is to align the correctness of method call usage.
{noformat}
    private static int defaultLength(ColumnType columnType, int precision) {
        switch (columnType) {
            case BITMASK:
            case STRING:
            case BYTE_ARRAY:
                return DEFAULT_VARLEN_LENGTH;
            default:
                return Math.max(DEFAULT_LENGTH, precision);
        }
    }
{noformat}



> Sql. CatalogUtils#defaultLength length derivation is not clear
> --------------------------------------------------------------
>
>                 Key: IGNITE-20432
>                 URL: https://issues.apache.org/jira/browse/IGNITE-20432
>             Project: Ignite
>          Issue Type: Improvement
>          Components: sql
>    Affects Versions: 3.0.0-beta1
>            Reporter: Evgeny Stanilovsky
>            Priority: Major
>              Labels: ignite-3
>
> For now below code part is commented with ignite-19938 TODO, which is not 
> relevant one.
> The goal of this issue is to align the correctness of method call usage.
> {noformat}
>     private static int defaultLength(ColumnType columnType, int precision) {
>         switch (columnType) {
>             case BITMASK:
>             case STRING:
>             case BYTE_ARRAY:
>                 return DEFAULT_VARLEN_LENGTH;
>             default:
>                 return Math.max(DEFAULT_LENGTH, precision);
>         }
>     }
> {noformat}
> Most probably we need amend just date/time 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to