[ 
https://issues.apache.org/jira/browse/IGNITE-19130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Evgeny Stanilovsky updated IGNITE-19130:
----------------------------------------
    Description: 
RexImpTable and RexToLixTranslator in apache ignite for now is a copy from 
outdated apache calcite, some functions already changed implementation  but 
apache ignite is not supported them due to outdated RexImpTable implementation. 
Propose: 
1. Somehow documented why we need such approach.
2. If only this way is convenient for now - copy actual implementation, adopt 
it and make further copy as simple as possible.


 

  was:
RexImpTable and RexToLixTranslator in apache ignite for now is a copy from 
outdated apache calcite, some functions already changed implementation and some 
additionally introduced (fow example ARG_MIN, ARG_MAX [1]) but apache ignite is 
not supported them due to outdated RexImpTable implementation. Propose: 
1. Somehow documented why we need such approach.
2. If only this way is convenient for now - copy actual implementation, change 
involved functions\fields access i.e. from private to protected and 
use\override appropriate methods in descendant implementation.

[1] https://issues.apache.org/jira/browse/CALCITE-5283

 


> Sql. Align RexImpTable implementation according to calcite current version.
> ---------------------------------------------------------------------------
>
>                 Key: IGNITE-19130
>                 URL: https://issues.apache.org/jira/browse/IGNITE-19130
>             Project: Ignite
>          Issue Type: Improvement
>          Components: sql
>    Affects Versions: 3.0.0-beta1
>            Reporter: Evgeny Stanilovsky
>            Assignee: Evgeny Stanilovsky
>            Priority: Major
>              Labels: calcite2-required, calcite3-required, ignite-3
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> RexImpTable and RexToLixTranslator in apache ignite for now is a copy from 
> outdated apache calcite, some functions already changed implementation  but 
> apache ignite is not supported them due to outdated RexImpTable 
> implementation. Propose: 
> 1. Somehow documented why we need such approach.
> 2. If only this way is convenient for now - copy actual implementation, adopt 
> it and make further copy as simple as possible.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to