[
https://issues.apache.org/jira/browse/IGNITE-18732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689609#comment-17689609
]
Denis Chudov commented on IGNITE-18732:
---------------------------------------
[~apolovtcev] LGTM
> Remove blocking calls from SchemaManager
> ----------------------------------------
>
> Key: IGNITE-18732
> URL: https://issues.apache.org/jira/browse/IGNITE-18732
> Project: Ignite
> Issue Type: Improvement
> Reporter: Aleksandr Polovtcev
> Assignee: Aleksandr Polovtcev
> Priority: Minor
> Labels: ignite-3, tech-debt
> Fix For: 3.0.0-beta2
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> {{SchemaManager}} class has two methods, that perform a blocking {{get}} call
> on a {{CompletableFuture}}: {{latestSchemaVersion}} and {{schemaByVersion}}.
> Instead, these methods should return the future and its callers must be
> rewritten in an asynchronous style.
> UPD: When removing blocking calls in SchemaManager, it was discovered, that
> {{fireEvent}} was called from the async part of the configuration listener.
> This is a problem, because {{fireEvent}} listeners call
> {{VersionedValue#update}} which can already be notified of the new
> configuration revision, in which case update will throw an exception.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
