[
https://issues.apache.org/jira/browse/IGNITE-16231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474498#comment-17474498
]
Konstantin Orlov commented on IGNITE-16231:
-------------------------------------------
Hi, [~v.pyatkov]. I've checked a SQL-related part of the provided patch and
have a some doubt about it. The approach when we relies on a TableEvent.ALTER
to create all necessary structures on table creation seems a bit
counterintuitive to me. Besides, a TableEvent.CREATE is still being fired at
the end of the table creation.
I believe it would be better either to stick with the current approach or
completely rework the events fired by TableManager.
> Use any() for tracking updates of schema
> ----------------------------------------
>
> Key: IGNITE-16231
> URL: https://issues.apache.org/jira/browse/IGNITE-16231
> Project: Ignite
> Issue Type: Improvement
> Reporter: Vladislav Pyatkov
> Assignee: Vladislav Pyatkov
> Priority: Major
> Labels: ignite-3
>
> In the ticket (IGNITE-15409), configuration began to provide API where any
> unknown part of configuration key can be replaced to any() function. It is
> convenient when subscribing of any nested sub-configuration, although the
> specific root has not created yet.
> This API makes sense for subscribing of schemas for table. Look at the
> comments in the code:
> {code:java}
> // TODO: IGNITE-15409 Listener with any placeholder should be used instead.
> ((ExtendedTableConfiguration) tablesCfg.tables().get(tblName)).schemas()
> .listenElements(new ConfigurationNamedListListener<>() {
> @Override
> public @NotNull CompletableFuture<?> onCreate(@NotNull
> ConfigurationNotificationEvent<SchemaView> schemasCtx) {...}
> }
> {code}
> Need to rewrite the code in order to use `any()` and remove the comment.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
