[
https://issues.apache.org/jira/browse/IGNITE-13883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256100#comment-17256100
]
Pavel Tupitsyn edited comment on IGNITE-13883 at 12/29/20, 6:27 PM:
--------------------------------------------------------------------
*BEFORE*
{code}
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 |
Allocated |
|-------
|---------:|----------:|----------:|-------:|------:|------:|----------:|
| Read | 2.063 us | 0.0089 us | 0.0084 us | 0.2823 | - | - | 1.74
KB |
{code}
*AFTER*
{code}
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 |
Allocated |
|-------
|---------:|----------:|----------:|-------:|------:|------:|----------:|
| Read | 1.792 us | 0.0080 us | 0.0071 us | 0.2728 | - | - | 1.67
KB |
{code}
(~13% improvement)
was (Author: ptupitsyn):
*BEFORE*
{code}
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 |
Allocated |
|-------
|---------:|----------:|----------:|-------:|------:|------:|----------:|
| Read | 2.063 us | 0.0089 us | 0.0084 us | 0.2823 | - | - | 1.74
KB |
{code}
*AFTER*
{code}
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 |
Allocated |
|-------
|---------:|----------:|----------:|-------:|------:|------:|----------:|
| Read | 1.792 us | 0.0080 us | 0.0071 us | 0.2728 | - | - | 1.67
KB |
{code}
> .NET: Performance: Refactor BinarySystemHandlers.TryReadSystemType to
> switch-case
> ---------------------------------------------------------------------------------
>
> Key: IGNITE-13883
> URL: https://issues.apache.org/jira/browse/IGNITE-13883
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
> Reporter: Pavel Tupitsyn
> Assignee: Pavel Tupitsyn
> Priority: Minor
> Labels: .NET
>
> {{BinarySystemHandlers.TryReadSystemType}} is too clever with interfaces and
> generics:
> * Hard to understand and maintain
> * Possibly causes overhead due to virtual method calls
> Refactor to switch-case and check if performance improves.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
