[ 
https://issues.apache.org/jira/browse/IGNITE-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178262#comment-15178262
 ] 

Andrey Gura commented on IGNITE-2757:
-------------------------------------

Test doesn't take into account all possible cases:

  * no events will be sent if task wasn't splitted to jobs yet
  * {{EVT_JOB_REJECTED}} will be sent if job was cancelled concurrently before 
was started
  * {{EVT_JOB_CANCELLED}} and {{EVT_JOB_FINISHED}} will be sent if job was 
started and then cancelled 

Fixed in PR https://github.com/apache/ignite/pull/535

Please review.

> [Failed test] Test GridTaskCancelSingleNodeSelfTest.testImmediateCancellation 
> fails in rare cases
> -------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-2757
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2757
>             Project: Ignite
>          Issue Type: Test
>            Reporter: Andrey Gura
>            Assignee: Andrey Gura
>              Labels: test
>             Fix For: 1.6
>
>
> Test {{GridTaskCancelSingleNodeSelfTest.testImmediateCancellation}} fails in 
> rare cases.
> {noformat}
> java.lang.AssertionError: Failed on iteration [i=2, finished=0, cancelled=0, 
> rejected=1]
>     at 
> org.apache.ignite.internal.GridTaskCancelSingleNodeSelfTest.checkCancellation(GridTaskCancelSingleNodeSelfTest.java:127)
>     at 
> org.apache.ignite.internal.GridTaskCancelSingleNodeSelfTest.testImmediateCancellation(GridTaskCancelSingleNodeSelfTest.java:64)
> {noformat}
> And more rare failures happen with:
> {noformat}
> java.lang.AssertionError: Failed on iteration [i=2, finished=1, cancelled=1, 
> rejected=0]
>     at 
> org.apache.ignite.internal.GridTaskCancelSingleNodeSelfTest.checkCancellation(GridTaskCancelSingleNodeSelfTest.java:127)
>     at 
> org.apache.ignite.internal.GridTaskCancelSingleNodeSelfTest.testImmediateCancellation(GridTaskCancelSingleNodeSelfTest.java:64)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to